Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use datatracker.ietf.org when referring to IETF RFCs and drafts #3374

Merged
merged 2 commits into from
Mar 9, 2021

Conversation

trustin
Copy link
Member

@trustin trustin commented Mar 8, 2021

Related issue: #3246

Motivation:

IETF now recommends referring to their new Datatracker web site rather
than tools.ietf.org, www.ietf.org, whatwg.org or www.rfc-editors.org.

Modifications:

  • Replace all IETF RFC and draft URLs with https://datatracker.ietf.org/.

Result:

  • Hyperlinked IETF RFC/draft pages look better.

Related issue: line#3246

Motivation:

IETF now recommends referring to their new Datatracker web site rather
than `tools.ietf.org`, `www.ietf.org` or `www.rfc-editors.org`.

Modifications:

- Replace all IETF RFC and draft URLs with `https://datatracker.ietf.org/`.

Result:

- Hyperlinked IETF RFC/draft pages look better.
@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #3374 (0c97d5c) into master (93a2b65) will increase coverage by 0.06%.
The diff coverage is 75.12%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3374      +/-   ##
============================================
+ Coverage     74.19%   74.25%   +0.06%     
- Complexity    13293    13332      +39     
============================================
  Files          1159     1160       +1     
  Lines         50740    50944     +204     
  Branches       6504     6534      +30     
============================================
+ Hits          37646    37830     +184     
- Misses         9775     9785      +10     
- Partials       3319     3329      +10     
Impacted Files Coverage Δ Complexity Δ
...p/armeria/common/throttling/ThrottlingHeaders.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...ria/server/throttling/bucket4j/BandwidthLimit.java 70.58% <ø> (ø) 18.00 <0.00> (ø)
...rmeria/server/throttling/bucket4j/TokenBucket.java 59.09% <ø> (ø) 8.00 <0.00> (ø)
...ia/server/throttling/bucket4j/TokenBucketSpec.java 91.66% <ø> (ø) 15.00 <0.00> (ø)
.../linecorp/armeria/client/ClientFactoryBuilder.java 76.49% <ø> (ø) 68.00 <0.00> (ø)
.../linecorp/armeria/client/ClientFactoryOptions.java 76.85% <ø> (ø) 35.00 <0.00> (ø)
...ecorp/armeria/client/ClientHttp1ObjectEncoder.java 88.88% <ø> (ø) 14.00 <0.00> (ø)
.../linecorp/armeria/client/ClientRequestContext.java 95.00% <ø> (+5.00%) 21.00 <0.00> (+1.00)
...necorp/armeria/client/DnsResolverGroupBuilder.java 48.93% <ø> (ø) 17.00 <0.00> (ø)
...ain/java/com/linecorp/armeria/client/Endpoint.java 90.96% <ø> (ø) 88.00 <0.00> (ø)
... and 75 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93a2b65...29bb458. Read the comment docs.

Copy link
Member

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@ikhoon ikhoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @trustin

Comment on lines +65 to +68
<module name="RegexpSingleline">
<property name="format" value="(http://datatracker\.ietf\.org|tools\.ietf\.org|rfc-editor\.org|(www\.ietf\.org|httpwg\.org|w3\.org)/[^ ]+/rfc)"/>
<property name="message" value="Use https://datatracker.ietf.org/ instead."/>
</module>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@trustin trustin merged commit 32eabd2 into line:master Mar 9, 2021
@trustin trustin deleted the update_ietf_urls branch March 9, 2021 11:46
@trustin trustin mentioned this pull request Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants