Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New I-D ratelimit ref #3264

Closed
ioggstream opened this issue Jan 5, 2021 · 3 comments
Closed

New I-D ratelimit ref #3264

ioggstream opened this issue Jan 5, 2021 · 3 comments
Labels
documentation
Milestone
1.6.0

Comments

@ioggstream
Copy link

Note

in https://github.com/ioggstream/armeria/blob/master/bucket4j/src/main/java/com/linecorp/armeria/common/throttling/ThrottlingHeaders.java#L30

you can reference the new I-D which is now under the IETF

 * <a href="https://tools.ietf.org/id/draft-ietf-httpapi-ratelimit-headers-00.html">RateLimit Header Scheme for HTTP</a>.
@trustin trustin added this to the 1.4.0 milestone Jan 5, 2021
@trustin
Copy link
Member

trustin commented Jan 5, 2021

Related: #3255

@trustin
Copy link
Member

trustin commented Jan 5, 2021

We also might want to check all other draft links (if any) and update accordingly.

@trustin trustin modified the milestones: 1.4.0, 1.5.0 Jan 30, 2021
@ikhoon ikhoon modified the milestones: 1.5.0, 1.6.0 Feb 15, 2021
@trustin
Copy link
Member

trustin commented Mar 26, 2021

Fixed via #3374

@trustin trustin closed this as completed Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
1.6.0
Development

No branches or pull requests
3 participants
@trustin @ioggstream @ikhoon