Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The ratelimit draft is now managed by the IETF #3246

Closed
wants to merge 1 commit into from

Conversation

ioggstream
Copy link

This PR

The RateLimit Headers draft has been adopted by the IETF httpapi workgroup.

Please provide feedback on the ongoing standardization work on https://github.com/ietf-wg-httpapi/ratelimit-headers
so that we can achieve the RFC status :)

The RateLimit Headers draft has been adopted by the IETF httpapi workgroup.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Dec 27, 2020

Codecov Report

Merging #3246 (452e291) into master (ccff172) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3246      +/-   ##
============================================
- Coverage     74.05%   74.05%   -0.01%     
- Complexity    12999    13003       +4     
============================================
  Files          1133     1133              
  Lines         49197    49197              
  Branches       6259     6259              
============================================
- Hits          36435    36431       -4     
- Misses         9546     9549       +3     
- Partials       3216     3217       +1     
Impacted Files Coverage Δ Complexity Δ
...p/armeria/common/throttling/ThrottlingHeaders.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...om/linecorp/armeria/client/HttpSessionHandler.java 71.59% <0.00%> (-9.47%) 49.00% <0.00%> (-5.00%)
...eria/internal/common/DefaultSplitHttpResponse.java 77.84% <0.00%> (-2.40%) 14.00% <0.00%> (ø%)
...linecorp/armeria/client/HttpRequestSubscriber.java 64.55% <0.00%> (-1.27%) 29.00% <0.00%> (-1.00%)
...p/armeria/internal/common/eureka/InstanceInfo.java 51.75% <0.00%> (-0.88%) 23.00% <0.00%> (-1.00%)
...inecorp/armeria/server/HttpResponseSubscriber.java 79.21% <0.00%> (-0.40%) 58.00% <0.00%> (ø%)
...corp/armeria/common/logging/DefaultRequestLog.java 76.42% <0.00%> (-0.26%) 223.00% <0.00%> (-1.00%)
...armeria/internal/common/CancellationScheduler.java 76.15% <0.00%> (+0.41%) 82.00% <0.00%> (+1.00%)
...java/com/linecorp/armeria/server/DefaultRoute.java 90.74% <0.00%> (+0.92%) 57.00% <0.00%> (+1.00%)
...necorp/armeria/client/HeapBasedEventLoopState.java 93.81% <0.00%> (+1.03%) 32.00% <0.00%> (+1.00%)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccff172...452e291. Read the comment docs.

@trustin
Copy link
Member

trustin commented Dec 28, 2020

Awesome! Thanks for your first contribution, @ioggstream 🙇 Would you mind signing the CLA?

@ikhoon ikhoon added this to the 1.4.0 milestone Dec 28, 2020
Copy link
Contributor

@ikhoon ikhoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know. Thanks! @ioggstream

@ikhoon
Copy link
Contributor

ikhoon commented Dec 31, 2020

Gentle ping @ioggstream. 😉

@trustin trustin modified the milestones: 1.4.0, 1.5.0 Jan 30, 2021
@ikhoon ikhoon modified the milestones: 1.5.0, 1.6.0 Feb 15, 2021
trustin added a commit to trustin/armeria that referenced this pull request Mar 8, 2021
Related issue: line#3246

Motivation:

IETF now recommends referring to their new Datatracker web site rather
than `tools.ietf.org`, `www.ietf.org` or `www.rfc-editors.org`.

Modifications:

- Replace all IETF RFC and draft URLs with `https://datatracker.ietf.org/`.

Result:

- Hyperlinked IETF RFC/draft pages look better.
@trustin
Copy link
Member

trustin commented Mar 8, 2021

Superseded by #3374. Thanks a lot for suggesting this, @ioggstream! I think @max904-github might have some feedback about your IETF draft by the way, since he is the main author of that functionality.

@trustin trustin closed this Mar 8, 2021
@ioggstream
Copy link
Author

Sure @max904-github let me know your feedback!

Moreover we are evaluating Structured-Fields https://www.rfc-editor.org/rfc/rfc8941.html which simplifies http header parsing too...

trustin added a commit that referenced this pull request Mar 9, 2021
Related issue: #3246

Motivation:

IETF now recommends referring to their new Datatracker web site rather
than `tools.ietf.org`, `www.ietf.org`, `whatwg.org` or `www.rfc-editors.org`.

Modifications:

- Replace all IETF RFC and draft URLs with `https://datatracker.ietf.org/`.

Result:

- Hyperlinked IETF RFC/draft pages look better.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants