Fix example and remove false deprecated message #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yang-33
commented
Oct 31, 2023
Comment on lines
+31
to
+43
| import ( | ||
| "github.com/line/line-bot-sdk-go/v7/linebot" | ||
| "github.com/line/line-bot-sdk-go/v7/linebot/channel_access_token" | ||
| "github.com/line/line-bot-sdk-go/v7/linebot/httphandler" | ||
| "github.com/line/line-bot-sdk-go/v7/linebot/insight" | ||
| "github.com/line/line-bot-sdk-go/v7/linebot/liff" | ||
| "github.com/line/line-bot-sdk-go/v7/linebot/manage_audience" | ||
| "github.com/line/line-bot-sdk-go/v7/linebot/messaging_api" | ||
| "github.com/line/line-bot-sdk-go/v7/linebot/module" | ||
| "github.com/line/line-bot-sdk-go/v7/linebot/module_attach" | ||
| "github.com/line/line-bot-sdk-go/v7/linebot/shop" | ||
| "github.com/line/line-bot-sdk-go/v7/linebot/webhook" | ||
| ) |
There was a problem hiding this comment.
for easy copy & paste
Yang-33
commented
Oct 31, 2023
| @@ -65,7 +83,7 @@ import ( | |||
| "github.com/line/line-bot-sdk-go/v7/linebot/webhook" | |||
| ) | |||
|
|
|||
| cb, err := webhook.ParseRequest(req) | |||
| cb, err := webhook.ParseRequest(os.Getenv("LINE_CHANNEL_SECRET"), req) | |||
There was a problem hiding this comment.
actually channel secret is necessary
Yang-33
commented
Oct 31, 2023
Comment on lines
+106
to
+114
| We provide code [examples](./examples). | ||
| - [EchoBot](./examples/echo_bot/server.go) | ||
| - a simple echo bot | ||
| - [KitchenSink](./examples/kitchensink/server.go) | ||
| - a bot that handles many types of events | ||
| - [EchoBotHandler](./examples/echo_bot_handler/server.go) | ||
| - [DeliveryHelper](./examples/delivery_helper/main.go) | ||
| - [InsightHelper](./examples/insight_helper/main.go) | ||
| - [RichmenuHelper](./examples/richmenu_helper/main.go) |
There was a problem hiding this comment.
I often hear SDK beginner doesn't know where is sample...
tokuhirom
reviewed
Oct 31, 2023
| @@ -15,7 +15,6 @@ var ( | |||
| ) | |||
|
|
|||
| // ParseRequest func | |||
| // Deprecated: Use OpenAPI based classes instead. | |||
tokuhirom
approved these changes
Oct 31, 2023
|
Thanks a lot!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.