-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WithResult methods to take HTTP headers, if needed. #387
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #387 +/- ##
=======================================
Coverage 55.68% 55.68%
=======================================
Files 86 86
Lines 5414 5414
=======================================
Hits 3015 3015
Misses 2179 2179
Partials 220 220 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
linebot/insight/api_insight.go
Outdated
date, | ||
) | ||
|
||
defer response.Body.Close() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there any problem calling defer response.Body.Close()
twice ...? ~WithHttpInfo
calls defer res.Body.Close()
and original methods call defer response.Body.Close()
again.
No description provided.