Hover state retained on window exit

[ghost]

Screen.Recording.2022-11-27.at.23.02.43.mov

I suspect this is not intended behavior? All hover state should be discarded on cursor exiting the window.

[xStrom]

Not intended and is not a problem in Druid last I checked. What macOS version do you have?

[ghost]

macOS Ventura 13.0.

[xStrom]

I see you also commented on glazier#38 - does that not fix this issue?

[ghost]

Before that PR, hover didn’t work at all. With that PR it does, but it’s not reset on window exit.

…

On 3. Dec 2022, at 17:23, Kaur Kuut ***@***.***> wrote:  I see you also commented on glazier#38 - does that not fix this issue? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

[longmathemagician]

This is a general druid shell / glazier event issue, the mouse leaving the window does not reset IS_HOT since the button is on the edge of the window. For whatever reason it stops sending mouse events when the cursor is outside the window.

At least on Windows this is actually a minor problem preventing platform-consistent implementation of button state management when you press, move the cursor outside the window, and then return it to the button to release.

[xStrom]

That's interesting and certainly sounds like a regression. All of this worked back in 2020 when I implemented it. I also did very extensive testing, with some of those results being reported in druid#828. I should revisit some of this stuff to see what's going on.

[longmathemagician]

Interesting. IIRC you'll only trigger it for isolated widgets (ones not in a layout or other container) or if you miss a mouse move event (eventually an issue for pen/touch support) so it would definitely be an easy regression to miss.

[longmathemagician]

I was able to reproduce this on linux and windows, turns out that mouse leave events were not being received in glazier or handled in xilem. The above draft PRs fix this (for x11) by adding a MouseLeft event. This could alternately be done just using MouseMove although doing so in druid was apparently problematic (linebender/druid#852 (comment)).

[longmathemagician]

Could someone with macOS 13 confirm if this is now fixed?

[Cupnfish]

2022-12-12.11.12.12.mov

Seems to be no problem @longmathemagician

[longmathemagician]

Awesome, thank you!