Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor (DownloadCall): Simplify the method DownloadCall::execute #170

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

refactormachine
Copy link

Problem: The method DownloadCall::execute is long and complex.
Solution: Refactor the method.
Extract a helper method to perform the main logic in a loop tryDownloadInLoop.
Extract 2 helper methods to calculate cause and realCause.
Simplify the "retry" loop logic.
The structure of the main logic is kept consistent with the diagram at https://github.com/lingochamp/okdownload/blob/master/CONTRIBUTING.md

Request for help
I work on semi-automatic refactoring pull requests.
If you want to help me help you, and you think this project will benefit from refactoring PRs, please click the link below.
Yes - I want a refactoring service
If this PR annoys you, please click on the link below, so I will stop doing it in other repos as well
No please - it annoys me
Assaf

…xecute.

Extract a helper method to perform the main logic in a loop `tryDownloadInLoop`.
Extract 2 helper methods to calculate `cause` and `realCause`.
Simplify the "retry" loop logic.
@rantianhua
Copy link
Collaborator

@refactormachine Sorry for so late response, please rebase master again and pr again, okdownload 1.0.6 have released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants