fix(core): sub entry export for react-native #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
thekip
changed the title
|
Can confirm that this PR fixes the React Native and Bundlephobia (tested locally)! 👍 |
Martin005
suggested changes
Jan 19, 2023
Co-authored-by: Martin Chrástek <chrastek12@gmail.com>
Martin005
approved these changes
Jan 19, 2023
|
@thekip @Martin005 thank you! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix #1347
Node 12+
@lingui/core/compile -> package.json exports -> build/cjs/compile.js
React Native or other older CJS runtimes not supporting
exports:@lingui/core/compile -> /compile.js -> build/cjs/compile.js
Development: Jest + Typescript Language Server
@lingui/core/compile -> tsconfig path mapping -> src/compile/index.ts
Guys, i'm on vacation till Monday, i haven't chance to test it with verdacio + /examples, i assume it would work, but better to test