Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't replace octothorpe coming from variable #1850

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

thekip
Copy link
Collaborator

@thekip thekip commented Feb 14, 2024

resolves #1826

Description

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Examples update

Fixes # (issue)

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

Copy link

vercel bot commented Feb 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2024 3:16pm

Copy link

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 2.81 KB (0%)
./packages/detect-locale/dist/index.mjs 723 B (0%)
./packages/react/dist/index.mjs 1.67 KB (0%)
./packages/remote-loader/dist/index.mjs 7.26 KB (0%)

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (685730f) 76.39% compared to head (dbb7100) 76.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1850      +/-   ##
==========================================
+ Coverage   76.39%   76.47%   +0.07%     
==========================================
  Files          81       81              
  Lines        2072     2079       +7     
  Branches      529      532       +3     
==========================================
+ Hits         1583     1590       +7     
  Misses        377      377              
  Partials      112      112              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thekip thank you!

@andrii-bodnar andrii-bodnar merged commit e321729 into lingui:main Feb 15, 2024
16 checks passed
@thekip thekip deleted the fix/octothorpe-replace branch February 15, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using Trans inside a Plural macro unexpectedly replaces "#" found in variables
2 participants