Fixing xcode project set-up that was causing some tests to fail #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmkk
approved these changes
Oct 30, 2019
The changes in this PR would fix the broken references in the above screenshot. |
Fixing xcode project set-up that was causing some tests to fail along with some other minor Xcode project related changes
ravimandala
added a commit
to ravimandala/bluepill
that referenced
this pull request
Oct 31, 2019
…leNativeFoundation#379) Fixing xcode project set-up that was causing some tests to fail along with some other minor Xcode project related changes
ravimandala
added a commit
to ravimandala/bluepill
that referenced
this pull request
Oct 31, 2019
…leNativeFoundation#379) Fixing xcode project set-up that was causing some tests to fail along with some other minor Xcode project related changes
ob
pushed a commit
that referenced
this pull request
Nov 1, 2019
…actoring (#378) * Fail if bp binary is not found adjacent to bluepill and also some refactoring Do not look for `bp` binary on `PATH` and simply fail if it is not found adjacent to `bluepill` binary. Also did some refactoring, cleanup and improvements like... 1. Moved a helper method to utils 2. Enhancing error messages and better error handling 3. Fixing asserts in tests 4. Renaming variables * Fixing xcode project set-up that was causing some tests to fail (#379) Fixing xcode project set-up that was causing some tests to fail along with some other minor Xcode project related changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the Xcode project set-up that was causing some tests to fail along with some other minor Xcode project-related changes.
Not sure how this issue got in, in the first place! Please review the changes.
\cc @ob @jmkk @chenxiao0228