[Master] Some refactoring and fail if bp binary is not found adjacent to bluepill binary #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravimandala
force-pushed
the
feature-minor-improvements
branch
from
a351d94
to
3f1f346
Compare
ob
approved these changes
Oct 31, 2019
ravimandala
force-pushed
the
feature-minor-improvements
branch
from
3f1f346
to
f1cbcf7
Compare
…actoring Do not look for `bp` binary on `PATH` and simply fail if it is not found adjacent to `bluepill` binary. Also did some refactoring, cleanup and improvements like... 1. Moved a helper method to utils 2. Enhancing error messages and better error handling 3. Fixing asserts in tests 4. Renaming variables
ravimandala
force-pushed
the
feature-minor-improvements
branch
from
f1cbcf7
to
932c36a
Compare
|
@ob Thank you Oscar, for your review. Please merge it as soon as the checks are done. |
ravimandala
added a commit
to ravimandala/bluepill
that referenced
this pull request
Oct 31, 2019
…actoring (MobileNativeFoundation#380) Do not look for `bp` binary on `PATH` and simply fail if it is not found adjacent to `bluepill` binary. Also did some refactoring, cleanup and improvements like... 1. Moved a helper method to utils 2. Enhancing error messages and better error handling 3. Fixing asserts in tests 4. Renaming variables
ravimandala
added a commit
to ravimandala/bluepill
that referenced
this pull request
Apr 3, 2020
…actoring (MobileNativeFoundation#380) Do not look for `bp` binary on `PATH` and simply fail if it is not found adjacent to `bluepill` binary. Also did some refactoring, cleanup and improvements like... 1. Moved a helper method to utils 2. Enhancing error messages and better error handling 3. Fixing asserts in tests 4. Renaming variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR Rebasing changes from #378 to be merged into master
Major change: Do not look for bp binary on PATH and simply fail if it is not found adjacent to the bluepill binary.
Also did some refactoring, cleanup and improvements like...
P.S: Works best if pushed after #379
\cc @ob @jmkk Please review.