feat(metabase): allow configuring how database engines get mapped to platforms #3869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iasoon
force-pushed
the
feature/metabase-ingestion-engine-platform-map
branch
from
f116be2
to
738a894
Compare
|
@iasoon : a build failure snuck in on master and is affecting your PR. Could you rebase? |
iasoon
force-pushed
the
feature/metabase-ingestion-engine-platform-map
branch
from
738a894
to
3e35a37
Compare
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to ingest data from a metabase setup which uses AWS Athena to read data registered in the AWS Glue metadata catalog. Currently the ingestion will create a new version of the dataset as an Athena table, instead of referring to the underlying glue dataset.
Allowing the user to configure the db engine -> platform mapping allows easily resolving issues like these, as well as supporting platforms not currently listed in the hardcoded mapping.
Checklist