using dust.isArray in place of Array.isArray

[jairodemorais]

No description provided.

[paulogaspar7]

@jairodemorais, you sure know much better your way around this code than me. =:o)

Sorry for the delay but had to test it at the office, where I had Internet Explorer and the original use case.

It worked with no problems. I will now try closing my (#235) pull request (if I can) since this is a better replacement.

[jairodemorais]

@paulogaspar7 thanks for testing it.

ASA my partners approve the change I will merge it.

[paulogaspar7]

Cool, thanks man!

[vybs]

what does this variable "comp" mean? , why not use a more descriptive name, if it refers to the compiler version

[jairodemorais]

The compiler function was executed immediately when you require ./compiler. this function receive the dust object as param. In the browser case, the dust object is obtained with the getGlobal function but in nodejs we don't have access to the dust object. So I have assigned the compiler function to a variable, comp, and if dust is being executed from browser I call it but if dust is being executed in node, I return the function, so the server can call it with the dust object.

[jairodemorais]

do you prefer calling it compiler? I can change it easily.

[vybs]

one more q: is this only relevant to node? or anything that works with server side?
I assume that latter?

[jairodemorais]

this is just for node, because the server file is just included when exports and process are different from "undefined"

if (typeof exports !== "undefined") {
  if (typeof process !== "undefined") {
      require('./server')(dust);
  }
  module.exports = dust;
}

[vybs]

why woud not it apply for rhino or nashhorn?

[jairodemorais]

Because Exports is undefined in Rhino.

I don't know in Nashorn.

I didn't know that we were maintaining dust compatible with it.

[vybs]

can we rename it to dustCompiler instead of comp?

[jairodemorais]

yes let me do it now.

[jairodemorais]

I send a new PR with the name change.
#243