GH-266 store rendered template in global #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rragan @jairodemorais @brikis98 review please. |
| if (context instanceof Context) { | ||
| return context; | ||
| } | ||
| return new Context(new Stack(context)); | ||
| var global= {}; | ||
| global._t = name; |
There was a problem hiding this comment.
_t is not a very descriptive name. Perhaps __template_name__?
There was a problem hiding this comment.
sure, will update PR soon.Thanks for the review.
|
Looks good overall and will definitely be very useful. I added just one minor comment on the variable name being clearer. |
vybs
added a commit
that referenced
this pull request
Jun 2, 2013
GH-266 store rendered template in global
|
retagging to 1.2.5 once the merge completes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#266