Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to add new vendor support e.g. Hipchat? #321

Closed
wleese opened this issue Nov 29, 2017 · 3 comments
Closed

How to add new vendor support e.g. Hipchat? #321

wleese opened this issue Nov 29, 2017 · 3 comments

Comments

@wleese
Copy link
Contributor

wleese commented Nov 29, 2017

I've implemented Hipchat support (./src/iris/vendors/iris_hipchat.py), but actually integrating this into Iris and Oncall isn't obvious to me.

In Iris, I can add a new mode (through a DB edit) called "hipchat". This is reflected in all the expected places in the UI.

Making a similar change to Oncall, for example in the contact_mode table, does not propagate any changes to the UI. Can I safely assume this is work in progress or am I missing something?

@jrgp
Copy link
Member

jrgp commented Nov 29, 2017

That should be all that's needed for it to work within iris. Would you be able to make a PR? :)

As for oncall, @dwang159 should be able to provide more context there.

@wleese
Copy link
Contributor Author

wleese commented Dec 1, 2017

#324

@wleese wleese mentioned this issue Dec 1, 2017
@jrgp
Copy link
Member

jrgp commented Dec 6, 2017

I think this can be closed as the PR was merged. This will/might require a similar PR on Oncall's end but it should be done for iris.

@jrgp jrgp closed this as completed Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants