Skip to content

Commit

Permalink
Explicitly set default value to "UNFINISHED" for TraceBuilder's Resul…
Browse files Browse the repository at this point in the history
…tType (#349)
  • Loading branch information
junchuanwang committed Mar 25, 2024
1 parent f6ab57d commit a2ab8d8
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 3 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
v5.1.19
------
* Explicitly set default value for TraceBuilder's ResultType to UNFINISHED to prevent null argument when building the trace in TraceBuilder.

v5.1.18
------
* Minor UI updates to trace visualizer to refresh JavaScript dependencies.
Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
version=5.1.18
version=5.1.19
group=com.linkedin.parseq
org.gradle.parallel=true
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ private SourcePointer(String className, String methodName, Integer lineNumber) {
.findFirst()
.map(SourcePointer::sourcePointer);
if (!ret.isPresent()) {
System.out.println("WARNING ParSeq cannot generate lambda function SourcePointer"
System.out.println("WARNING: ParSeq cannot generate lambda function SourcePointer."
+ "source stacktrace will be printed:");
exception.printStackTrace();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public class ShallowTraceBuilder {
private volatile String _name;
private volatile boolean _hidden;
private volatile String _value;
private volatile ResultType _resultType;
private volatile ResultType _resultType = ResultType.UNFINISHED;
private volatile long _startNanos = -1;
private volatile long _pendingNanos = -1;
private volatile long _endNanos = -1;
Expand Down

0 comments on commit a2ab8d8

Please sign in to comment.