Disable string interning in Jackson JSON since it causes GC issues #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aman1309
reviewed
Jul 2, 2020
data/src/main/java/com/linkedin/data/codec/entitystream/AbstractJacksonDataEncoder.java
Outdated
Show resolved
Hide resolved
aman1309
reviewed
Jul 2, 2020
data/src/main/java/com/linkedin/data/codec/JacksonDataCodec.java
Outdated
Show resolved
Hide resolved
karthikrg
force-pushed
the
master
branch
2 times, most recently
from
3af70bd
to
98b98a7
Compare
aman1309
approved these changes
Jul 2, 2020
data/src/main/java/com/linkedin/data/codec/entitystream/AbstractJacksonDataEncoder.java
Outdated
Show resolved
Hide resolved
data/src/main/java/com/linkedin/data/codec/AbstractJacksonDataCodec.java
Outdated
Show resolved
Hide resolved
|
Also, please update the commit description to include the batch_get issue wrt interning |
…C issues. Make JsonFactory parameterized so that multiple codec instances can share the same factory if necessary
karthikbalasub
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interning seems to be messing with batch_get where the keys are not schema but are values, resulting in a large number of strings being interned.