Add RestLiTraceInfo to the request context for both client and server… #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanw555
reviewed
Oct 4, 2022
restli-server/src/main/java/com/linkedin/restli/server/ResourceDefinition.java
Outdated
Show resolved
Hide resolved
...server/src/main/java/com/linkedin/restli/internal/server/model/ResourceMethodDescriptor.java
Show resolved
Hide resolved
evanw555
reviewed
Oct 4, 2022
restli-common/src/main/java/com/linkedin/restli/common/ResourceMethodIdentifierGenerator.java
Outdated
Show resolved
Hide resolved
evanw555
reviewed
Oct 4, 2022
restli-common/src/main/java/com/linkedin/restli/common/ResourceMethodIdentifierGenerator.java
Show resolved
Hide resolved
evanw555
reviewed
Oct 4, 2022
restli-common/src/main/java/com/linkedin/restli/common/RestLiTraceInfo.java
Show resolved
Hide resolved
|
You're adding new APIs in various places, so please bump the minor version. Also, update |
evanw555
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent is to provide additional Rest.Li trace information to R2 by packaging this info into a RestLiTraceInfo bean and adding it to the request context for both incoming and outgoing requests. The main id is the resourceMethodIdentifier in the form: stripped(baseUriTemplate) + ':' + . Example: album/photo:get or album:action:purgeAll. Note that keys are stripped from the baseUriTemplate when generating the identifier.
For outgoing requests, the identifier is available via Request.getResourceMethodIdentifier(). For incoming requests, the identifier is available via ResourceMethodDescriptor.getResourceMethodIdentifier(). (The baseUriTemplate is also available from the ResourceMethodDescriptor.)