Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crds(feat): add gateway grpcroute crd #12507

Merged
merged 39 commits into from
May 6, 2024
Merged

crds(feat): add gateway grpcroute crd #12507

merged 39 commits into from
May 6, 2024

Conversation

the-wondersmith
Copy link
Contributor

Subject

Kubernetes Gateway API CRDs

Problem

In order to support driving traffic via Gateway GRPCRoute
resources, the requisite CRD needs to be added to the linkerd-crds.

Solution

  • Mirror the same feature gating used for HTTPRoute
  • Add the GRPCRoute CRD to the linkerd-crds templates
  • Use helm's lookup function to ensure that installation of linkerd-crds does not fail due to pre-existing installation of Gateway API CRDs or cause pre-existing Gateway API CRDs to be "absorbed" into a linkerd-crds installation

Validation

  • helm install works as expected
  • helm upgrade works as expected
  • ensure bin/linkerd install --crds --set enableGrpcRoutes=true outputs the grpcroute CRD manifest
  • ensure bin/linkerd install --crds --set endableGrpcRoutes=true | kubectl apply -f - correctly installs the grpcroute CRD onto the cluster
  • run go test ./... --update to automatically update any test fixtures that need to be updated
  • ensure go test ./... passes

Screenshots

Screenshot 2024-04-24 at 10 01 46 AM Screenshot 2024-04-24 at 10 01 40 AM

Fixes Partially Addresses

@the-wondersmith the-wondersmith marked this pull request as ready for review April 25, 2024 21:33
@the-wondersmith the-wondersmith requested a review from a team as a code owner April 25, 2024 21:33
the-wondersmith and others added 16 commits April 29, 2024 09:24
@the-wondersmith
feat(crds): add gateway grpcroute crd
94d8cc4 
Signed-off-by: Mark S <the@wondersmith.dev>
@the-wondersmith
feat(cli): add gateway grpcroute crd
f775b7f 
Signed-off-by: Mark S <the@wondersmith.dev>
@the-wondersmith
chore(tests): update crd and helm golden outputs
ecbefc8 
Signed-off-by: Mark S <the@wondersmith.dev>
@dependabot @the-wondersmith
build(deps): bump actions/download-artifact from 4.1.6 to 4.1.7 (link…
52a2294 
…erd#12503)

Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 4.1.6 to 4.1.7.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@9c19ed7...65a9edc)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Mark S <the@wondersmith.dev>
@dependabot @the-wondersmith
build(deps): bump zeroize from 1.7.0 to 1.8.0 (linkerd#12501)
c6780ac 
Bumps [zeroize](https://github.com/RustCrypto/utils) from 1.7.0 to 1.8.0.
- [Commits](RustCrypto/utils@zeroize-v1.7.0...zeroize-v1.8.0)

---
updated-dependencies:
- dependency-name: zeroize
  dependency-type: indirect
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Mark S <the@wondersmith.dev>
@dependabot @the-wondersmith
build(deps): bump actions/checkout from 4.1.3 to 4.1.4 (linkerd#12502)
7713deb 
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.3 to 4.1.4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@1d96c77...0ad4b8f)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Mark S <the@wondersmith.dev>
@DrFaust92 @the-wondersmith
Helm Chart - allow setting revisionHistoryLimit (linkerd#12234)
5f7cf8a 
Signed-off-by: Mark S <the@wondersmith.dev>
@dependabot @the-wondersmith
build(deps): bump lock_api from 0.4.11 to 0.4.12 (linkerd#12511)
3c1c8ed 
Bumps [lock_api](https://github.com/Amanieu/parking_lot) from 0.4.11 to 0.4.12.
- [Changelog](https://github.com/Amanieu/parking_lot/blob/master/CHANGELOG.md)
- [Commits](Amanieu/parking_lot@lock_api-0.4.11...lock_api-0.4.12)

---
updated-dependencies:
- dependency-name: lock_api
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Mark S <the@wondersmith.dev>
@dependabot @the-wondersmith
build(deps): bump parking_lot from 0.12.1 to 0.12.2 (linkerd#12510)
5132c5b 
Bumps [parking_lot](https://github.com/Amanieu/parking_lot) from 0.12.1 to 0.12.2.
- [Changelog](https://github.com/Amanieu/parking_lot/blob/master/CHANGELOG.md)
- [Commits](Amanieu/parking_lot@0.12.1...0.12.2)

---
updated-dependencies:
- dependency-name: parking_lot
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Mark S <the@wondersmith.dev>
@marwanad @the-wondersmith
fix: avoid unnecessary headless endpoint mirrors cleanups during GC (l…
f28df7c 
…inkerd#12500)

Subject
Fixes a bug where headless endpoint mirrors get cleaned up during GC

Problem
When GC is triggered (which also happens at startup or when the link watch disconnects), the service mirror controller attempts to look for services that can be GC'ed. This is done by looping through the local mirrored services on the cluster, then extracting the name of the original service in the remote (by dropping the target name suffix).

However, this check doesn't account for the headless endpoint service mirrors (the per pod cluster IP services). For example, if you have nginx-svc in the west cluster and two replicas, the source cluster will end up with nginx-svc-west, nginx-set-0-west and nginx-set-1-west. The logic would then parse the resource name for the latter two services as nginx-set-0 and nginx-set-1 which won't exist on the remote and ends up deleting them as part of GC.

The next sync would recreate those mirrors but you end up with downtime.

Solution
For those cases, instead of parsing the remote resource from the local service name, retrieve the info from the `mirror.linkerd.io/headless-mirror-svc-name` label.

Validation
Unit tests

Fixes linkerd#12499

Signed-off-by: Marwan Ahmed <me@marwanad.com>
Signed-off-by: Mark S <the@wondersmith.dev>
@alpeb @the-wondersmith
Fix issues with native sidecars (linkerd#12453)
f53aae8 
Closes linkerd#12395

Failing to iterate over init containers as well as regular containers for finding the proxy in various parts of the code when the proxy is injected as a native sidecar resulted in:

- `Get` Destination API failing in the presence of opaque ports
- Failure having the injector detecting already injected pods
- Various CLI issues

This PR is split into the following commits addressing each issue separately:

a8ebe76 - Fix injection check for existing sidecars
44e9625 - Fix 'linkerd uninject'
6269496 - Fix 'linkerd version --proxy'
42dbdad - Fix 'linkerd identity'
39db823 - Fix 'linkerd check'
7359f37 - Fix 'linkerd dg proxy-metrics'
f8f73c4 - Fix destination controller

Signed-off-by: Mark S <the@wondersmith.dev>
@dependabot @the-wondersmith
build(deps): bump serde from 1.0.198 to 1.0.199 (linkerd#12515)
a3d1b04 
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.198 to 1.0.199.
- [Release notes](https://github.com/serde-rs/serde/releases)
- [Commits](serde-rs/serde@v1.0.198...v1.0.199)

---
updated-dependencies:
- dependency-name: serde
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Mark S <the@wondersmith.dev>
@dependabot @the-wondersmith
build(deps): bump rustls from 0.21.11 to 0.21.12 (linkerd#12517)
c937538 
Bumps [rustls](https://github.com/rustls/rustls) from 0.21.11 to 0.21.12.
- [Release notes](https://github.com/rustls/rustls/releases)
- [Changelog](https://github.com/rustls/rustls/blob/main/CHANGELOG.md)
- [Commits](rustls/rustls@v/0.21.11...v/0.21.12)

---
updated-dependencies:
- dependency-name: rustls
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Mark S <the@wondersmith.dev>
@dependabot @the-wondersmith
build(deps): bump schemars from 0.8.16 to 0.8.17 (linkerd#12518)
5d42a30 
Bumps [schemars](https://github.com/GREsau/schemars) from 0.8.16 to 0.8.17.
- [Release notes](https://github.com/GREsau/schemars/releases)
- [Changelog](https://github.com/GREsau/schemars/blob/master/CHANGELOG.md)
- [Commits](GREsau/schemars@v0.8.16...v0.8.17)

---
updated-dependencies:
- dependency-name: schemars
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Mark S <the@wondersmith.dev>
@dependabot @the-wondersmith
build(deps): bump parking_lot_core from 0.9.9 to 0.9.10 (linkerd#12509)
f2102da 
Bumps [parking_lot_core](https://github.com/Amanieu/parking_lot) from 0.9.9 to 0.9.10.
- [Changelog](https://github.com/Amanieu/parking_lot/blob/master/CHANGELOG.md)
- [Commits](Amanieu/parking_lot@core-0.9.9...core-0.9.10)

---
updated-dependencies:
- dependency-name: parking_lot_core
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Mark S <the@wondersmith.dev>
@the-wondersmith
refactor: move all gateway api crds behind enableGatewayAPICRDs flag
65bc2b1 
Signed-off-by: Mark S <the@wondersmith.dev>
olix0r
olix0r reviewed May 3, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@the-wondersmith
build(deps): remove k8s-gateway-api patch
f986037 
Signed-off-by: Mark S <the@wondersmith.dev>
@the-wondersmith the-wondersmith force-pushed the crds-feat-add-gateway-grpcroute branch from 0463918 to f986037 Compare May 3, 2024 19:33
olix0r
olix0r previously approved these changes May 3, 2024
View reviewed changes
@olix0r olix0r dismissed their stale review May 3, 2024 20:11

cargo.lock

olix0r
olix0r reviewed May 3, 2024
View reviewed changes
Cargo.lock Outdated Show resolved Hide resolved
charts/linkerd-crds/templates/gateway.networking.k8s.io_grpcroutes.yaml Outdated Show resolved Hide resolved
@the-wondersmith
chore: standardize gateway api crds @ v0.7.1
cbabaeb 
Signed-off-by: Mark S <the@wondersmith.dev>
@the-wondersmith
revert: sync with upstream/main
e628211 
Signed-off-by: Mark S <the@wondersmith.dev>
@olix0r olix0r merged commit e641d07 into linkerd:main May 6, 2024
37 checks passed
@the-wondersmith the-wondersmith deleted the crds-feat-add-gateway-grpcroute branch May 9, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olix0r olix0r olix0r approved these changes

@adleong adleong adleong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@the-wondersmith @olix0r @adleong @DrFaust92 @marwanad @alpeb