policy: Support Gateway API GRPCRoute resources #12404
Labels
Comments
This was referenced Apr 22, 2024
1 task
This was referenced May 30, 2024
adleong
pushed a commit
that referenced
this issue
Jun 3, 2024
## Subject Prepare to expand `linkerd`'s repertoire of supported [`Gateway API`](https://gateway-api.sigs.k8s.io/api-types/grpcroute/) route types in [`linkerd-policy-controller-k8s-status`](https://github.com/linkerd/linkerd2/tree/main/policy-controller/k8s/status). ## Problem Currently, the policy controller's `status` component is written with `HTTPRoute` support (effectively) exclusively, both in its structure/organization as well as its naming (e.g. `HttpRoute` as a primary type name, `update_http_route` as a method name, etc...). In order to expand `linkerd`'s support for the route types defined by the Gateway API, the policy controller's `status` component needs to be made more generic in both respects. ## Solution > **NOTE:** PR was opened out of order and should only be merged _after_ #12662 PR introduces structural and naming changes making the codebase generic with respect to the type of route being handled (e.g. `HTTPRoute` -> `Route`). Changes are almost entirely cosmetic introducing only a couple of minor functional changes, most notably: - making the `status` argument to [`make_patch`](https://github.com/the-wondersmith/linkerd2/blob/8d6cd57b70110daccc38288aaac8a7c04091c5fc/policy-controller/k8s/status/src/index.rs#L734) generic - adding a type-aware `api_version` helper method to [`NamespaceGroupKindName`](https://github.com/the-wondersmith/linkerd2/blob/8d6cd57b70110daccc38288aaac8a7c04091c5fc/policy-controller/k8s/status/src/resource_id.rs#L27) - **note:** *required for proper handling of different route types in the future* ## Validation - [X] maintainer review - [X] tests pass  ## ~~Fixes~~ *Lays Groundwork For Addressing* - #12404 Signed-off-by: Mark S <the@wondersmith.dev>
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Linkerd supports the Gateway API's HTTPRoute resource for both inbound and outbound policy. Linkerd's Proxy API already includes GrpcRoute types; and the proxy has nascent support for consuming these routes, though this functionality has not been integration-tested, as the control plane's support was not introduced.
To support GRPCRoute in Linkerd, several changes need to be made:
The text was updated successfully, but these errors were encountered: