-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Last changes before submitting to the Helm incubator #3292
Conversation
Integration test results for cb8d98a: success 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As they require that all dependencies are also published, I suspect we'll want a little helm publishing script that gets rid of requirements.*
and moves the partials chart templates in here as a helper eventually.
I was gonna say we push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together 👍. Some comments below.
Integration test results for ac66857: success 🎉 |
Integration test results for 036a116: success 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- Added missing OWNERS and README files - Added maintainers section to Chart.yaml - Changed NOTES.txt so it points to the installation of the CLI - Set the proxy-init version to v1.1.0 in values.yaml Ref #3256 Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
… the Identity.Issuer.CrtExpiryAnnotation value Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
7469bfd
to
22ccd3d
Compare
Integration test results for 22ccd3d: success 🎉 |
The Helm incubator repo is kind of deprecated and should not be used anymore for new charts. See: helm/charts#13869 (comment) It's even questionsnable to use the stable repo as the helm devs suggest to use own Helm repos. See: helm/charts#5071 (comment) Own Helm repos can be created easily on Github pages, so you wont even need own infrastructure for hosting it. You could use an official Helm tool for that: https://github.com/helm/chart-releaser |
Thanks for the feedback @monotek! We'll consider that and report back. |
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
The last push adds the option [ |
Given that we are creating our own repo (#3365), are these changes still necessary? |
Actually this PR has morphed into the changes to be done for supporting our own repo. You can see more details at linkerd/website#502 |
Changed `bin/helm-build`'s `(-stable|-edge)` flag to `deploy`. It will automatically extract the repo (edge or stable) and version from git. Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Ref linkerd/website#502 Adds a new final step into `workflow.yml` to generate and push the Helm artifacts. This depends on the changes made to `bin/helm-build` in #3292 so this branch is based on that one till it gets merged. Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates. I think we should merge this, regardless of the status of the incubator PR, as these changes are relevant to our chart in general.
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Ref #3256