Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last changes before submitting to the Helm incubator #3292

Merged
merged 16 commits into from
Sep 10, 2019

Conversation

alpeb
Copy link
Member

@alpeb alpeb commented Aug 20, 2019

  • Added missing OWNERS and README files
  • Added maintainers section to Chart.yaml
  • Changed NOTES.txt so it points to the installation of the CLI
  • Set the proxy-init version to v1.1.0 in values.yaml

Ref #3256

@alpeb alpeb self-assigned this Aug 20, 2019
@alpeb alpeb added this to In progress in 2.6 - Release via automation Aug 20, 2019
@l5d-bot
Copy link
Collaborator

l5d-bot commented Aug 20, 2019

Integration test results for cb8d98a: success 🎉
Log output: https://gist.github.com/bcf5721c2c19609105cafcdd7cd7222c

Copy link
Contributor

@grampelberg grampelberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As they require that all dependencies are also published, I suspect we'll want a little helm publishing script that gets rid of requirements.* and moves the partials chart templates in here as a helper eventually.

charts/linkerd2/Chart.yaml Show resolved Hide resolved
@alpeb
Copy link
Member Author

alpeb commented Aug 20, 2019

As they require that all dependencies are also published, I suspect we'll want a little helm publishing script that gets rid of requirements.* and moves the partials chart templates in here as a helper eventually.

I was gonna say we push linkerd2/charts/partials-0.1.0.tgz that we're already generating with bin/helm-build, but I've searched through all Helm stable charts and nobody does that 😊
So yeah, we can just explode that tarball, manually at first and then through some script.

Copy link
Contributor

@ihcsim ihcsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together 👍. Some comments below.

charts/linkerd2/README.md Show resolved Hide resolved
charts/linkerd2/README.md Show resolved Hide resolved
charts/linkerd2/README.md Show resolved Hide resolved
charts/linkerd2/README.md Outdated Show resolved Hide resolved
charts/linkerd2/README.md Outdated Show resolved Hide resolved
charts/linkerd2/README.md Outdated Show resolved Hide resolved
charts/linkerd2/README.md Outdated Show resolved Hide resolved
charts/linkerd2/README.md Outdated Show resolved Hide resolved
@l5d-bot
Copy link
Collaborator

l5d-bot commented Aug 20, 2019

Integration test results for ac66857: success 🎉
Log output: https://gist.github.com/30d92788a4480d1c203dae523aa3d5e4

charts/linkerd2/README.md Outdated Show resolved Hide resolved
charts/linkerd2/README.md Outdated Show resolved Hide resolved
charts/linkerd2/README.md Outdated Show resolved Hide resolved
@l5d-bot
Copy link
Collaborator

l5d-bot commented Aug 20, 2019

Integration test results for 036a116: success 🎉
Log output: https://gist.github.com/028ba45f34592c53c82ed5c359623371

2.6 - Release automation moved this from In progress to Reviewer approved Aug 20, 2019
Copy link
Contributor

@ihcsim ihcsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

- Added missing OWNERS and README files
- Added maintainers section to  Chart.yaml
- Changed NOTES.txt so it points to the installation of the CLI
- Set the proxy-init version to v1.1.0 in values.yaml

Ref #3256

Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
… the Identity.Issuer.CrtExpiryAnnotation value

Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
@alpeb alpeb force-pushed the alpeb/helm-chart-publishing branch from 7469bfd to 22ccd3d Compare August 20, 2019 21:34
@l5d-bot
Copy link
Collaborator

l5d-bot commented Aug 20, 2019

Integration test results for 22ccd3d: success 🎉
Log output: https://gist.github.com/0e0d9023497027619156a54c566f1564

@monotek
Copy link

monotek commented Aug 22, 2019

The Helm incubator repo is kind of deprecated and should not be used anymore for new charts. See: helm/charts#13869 (comment)

It's even questionsnable to use the stable repo as the helm devs suggest to use own Helm repos. See: helm/charts#5071 (comment)

Own Helm repos can be created easily on Github pages, so you wont even need own infrastructure for hosting it. You could use an official Helm tool for that: https://github.com/helm/chart-releaser

@alpeb
Copy link
Member Author

alpeb commented Aug 22, 2019

Thanks for the feedback @monotek! We'll consider that and report back.

Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
@alpeb
Copy link
Member Author

alpeb commented Sep 5, 2019

The last push adds the option [-stable | -edge] to bin/helm-build which generates the index.yaml and the helm chart tarball that we'll serve in the website in the repos https://run.linkerd.io/stable and https://run.linkerd.io/edge as per linkerd/website#502

@alpeb alpeb moved this from Reviewer approved to Review in progress in 2.6 - Release Sep 5, 2019
@cpretzer
Copy link
Contributor

cpretzer commented Sep 8, 2019

Given that we are creating our own repo (#3365), are these changes still necessary?

@alpeb
Copy link
Member Author

alpeb commented Sep 9, 2019

Given that we are creating our own repo (#3365), are these changes still necessary?

Actually this PR has morphed into the changes to be done for supporting our own repo. You can see more details at linkerd/website#502

Changed `bin/helm-build`'s `(-stable|-edge)` flag to `deploy`. It will
automatically extract the repo (edge or stable) and version from git.

Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
alpeb added a commit that referenced this pull request Sep 10, 2019
Ref linkerd/website#502

Adds a new final step into `workflow.yml` to generate and push the Helm
artifacts.

This depends on the changes made to `bin/helm-build` in #3292 so this
branch is based on that one till it gets merged.

Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
2.6 - Release automation moved this from Review in progress to Reviewer approved Sep 10, 2019
Copy link
Contributor

@ihcsim ihcsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. I think we should merge this, regardless of the status of the incubator PR, as these changes are relevant to our chart in general.

charts/linkerd2/README.md Outdated Show resolved Hide resolved
charts/linkerd2/README.md Outdated Show resolved Hide resolved
charts/linkerd2/README.md Show resolved Hide resolved
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
@alpeb alpeb merged commit bd702b9 into master Sep 10, 2019
2.6 - Release automation moved this from Reviewer approved to Done Sep 10, 2019
@olix0r olix0r deleted the alpeb/helm-chart-publishing branch October 13, 2020 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
2.6 - Release
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants