Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last changes before submitting to the Helm incubator #3292

Merged
merged 16 commits into from Sep 10, 2019

Conversation

@alpeb
Copy link
Member

commented Aug 20, 2019

  • Added missing OWNERS and README files
  • Added maintainers section to Chart.yaml
  • Changed NOTES.txt so it points to the installation of the CLI
  • Set the proxy-init version to v1.1.0 in values.yaml

Ref #3256

@alpeb alpeb added the area/install label Aug 20, 2019

@alpeb alpeb requested review from grampelberg and ihcsim Aug 20, 2019

@alpeb alpeb self-assigned this Aug 20, 2019

@alpeb alpeb added this to In progress in 2.6 - Release via automation Aug 20, 2019

@l5d-bot

This comment has been minimized.

Copy link

commented Aug 20, 2019

Integration test results for cb8d98a: success 🎉
Log output: https://gist.github.com/bcf5721c2c19609105cafcdd7cd7222c

@grampelberg
Copy link
Member

left a comment

As they require that all dependencies are also published, I suspect we'll want a little helm publishing script that gets rid of requirements.* and moves the partials chart templates in here as a helper eventually.

charts/linkerd2/Chart.yaml Show resolved Hide resolved
@alpeb

This comment has been minimized.

Copy link
Member Author

commented Aug 20, 2019

As they require that all dependencies are also published, I suspect we'll want a little helm publishing script that gets rid of requirements.* and moves the partials chart templates in here as a helper eventually.

I was gonna say we push linkerd2/charts/partials-0.1.0.tgz that we're already generating with bin/helm-build, but I've searched through all Helm stable charts and nobody does that 😊
So yeah, we can just explode that tarball, manually at first and then through some script.

@ihcsim
Copy link
Member

left a comment

Thanks for putting this together 👍. Some comments below.

charts/linkerd2/README.md Show resolved Hide resolved
charts/linkerd2/README.md Show resolved Hide resolved
charts/linkerd2/README.md Show resolved Hide resolved
charts/linkerd2/README.md Outdated Show resolved Hide resolved
charts/linkerd2/README.md Outdated Show resolved Hide resolved
charts/linkerd2/README.md Outdated Show resolved Hide resolved
charts/linkerd2/README.md Outdated Show resolved Hide resolved
charts/linkerd2/README.md Outdated Show resolved Hide resolved
@l5d-bot

This comment has been minimized.

Copy link

commented Aug 20, 2019

Integration test results for ac66857: success 🎉
Log output: https://gist.github.com/30d92788a4480d1c203dae523aa3d5e4

charts/linkerd2/README.md Outdated Show resolved Hide resolved
charts/linkerd2/README.md Outdated Show resolved Hide resolved
charts/linkerd2/README.md Outdated Show resolved Hide resolved
@l5d-bot

This comment has been minimized.

Copy link

commented Aug 20, 2019

Integration test results for 036a116: success 🎉
Log output: https://gist.github.com/028ba45f34592c53c82ed5c359623371

2.6 - Release automation moved this from In progress to Reviewer approved Aug 20, 2019

@ihcsim
ihcsim approved these changes Aug 20, 2019
Copy link
Member

left a comment

👍

alpeb added 7 commits Aug 20, 2019
Last changes before submitting to the Helm incubator
- Added missing OWNERS and README files
- Added maintainers section to  Chart.yaml
- Changed NOTES.txt so it points to the installation of the CLI
- Set the proxy-init version to v1.1.0 in values.yaml

Ref #3256

Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Change maintainers
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
I had forgotten the URL
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Use the dev mailing list instead
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Ivan feedback
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Add notes about ECDSA and s/Memory/memory
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Added missing ProfileValidator vars, and add 'do not edit' comment to…
… the Identity.Issuer.CrtExpiryAnnotation value

Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>

@alpeb alpeb force-pushed the alpeb/helm-chart-publishing branch from 7469bfd to 22ccd3d Aug 20, 2019

@l5d-bot

This comment has been minimized.

Copy link

commented Aug 20, 2019

Integration test results for 22ccd3d: success 🎉
Log output: https://gist.github.com/0e0d9023497027619156a54c566f1564

@monotek

This comment has been minimized.

Copy link

commented Aug 22, 2019

The Helm incubator repo is kind of deprecated and should not be used anymore for new charts. See: helm/charts#13869 (comment)

It's even questionsnable to use the stable repo as the helm devs suggest to use own Helm repos. See: helm/charts#5071 (comment)

Own Helm repos can be created easily on Github pages, so you wont even need own infrastructure for hosting it. You could use an official Helm tool for that: https://github.com/helm/chart-releaser

@alpeb

This comment has been minimized.

Copy link
Member Author

commented Aug 22, 2019

Thanks for the feedback @monotek! We'll consider that and report back.

alpeb added 4 commits Sep 4, 2019
Add new self-hosted repo
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Add linkerd Helm repo instructions
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Add option to bin/helm
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
@alpeb

This comment has been minimized.

Copy link
Member Author

commented Sep 5, 2019

The last push adds the option [-stable | -edge] to bin/helm-build which generates the index.yaml and the helm chart tarball that we'll serve in the website in the repos https://run.linkerd.io/stable and https://run.linkerd.io/edge as per linkerd/website#502

@alpeb alpeb moved this from Reviewer approved to Review in progress in 2.6 - Release Sep 5, 2019

@cpretzer

This comment has been minimized.

Copy link
Member

commented Sep 8, 2019

Given that we are creating our own repo (#3365), are these changes still necessary?

@alpeb

This comment has been minimized.

Copy link
Member Author

commented Sep 9, 2019

Given that we are creating our own repo (#3365), are these changes still necessary?

Actually this PR has morphed into the changes to be done for supporting our own repo. You can see more details at linkerd/website#502

alpeb added 4 commits Sep 9, 2019
Refactor `bin/helm-build`
Changed `bin/helm-build`'s `(-stable|-edge)` flag to `deploy`. It will
automatically extract the repo (edge or stable) and version from git.

Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Changed 'deploy' with 'package'
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Create Helm artifacts under target/helm
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
alpeb added a commit that referenced this pull request Sep 10, 2019
Add chart_deploy into workflow.yml
Ref linkerd/website#502

Adds a new final step into `workflow.yml` to generate and push the Helm
artifacts.

This depends on the changes made to `bin/helm-build` in #3292 so this
branch is based on that one till it gets merged.

Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>

2.6 - Release automation moved this from Review in progress to Reviewer approved Sep 10, 2019

@ihcsim
ihcsim approved these changes Sep 10, 2019
Copy link
Member

left a comment

Thanks for the updates. I think we should merge this, regardless of the status of the incubator PR, as these changes are relevant to our chart in general.

charts/linkerd2/README.md Outdated Show resolved Hide resolved
charts/linkerd2/README.md Outdated Show resolved Hide resolved
charts/linkerd2/README.md Show resolved Hide resolved
Change repo names and added DisableHeartBeat
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>

@alpeb alpeb merged commit bd702b9 into master Sep 10, 2019

19 checks passed

Validate go deps
Details
Go unit tests
Details
Go lint
Details
JS unit tests
Details
Docker pull
Details
Docker build
Details
Cluster setup (deep)
Details
Cluster setup (upgrade)
Details
Cluster setup (helm)
Details
Integration tests (deep)
Details
Integration tests (upgrade)
Details
Integration tests (helm)
Details
Cluster cleanup (deep)
Details
Cluster cleanup (upgrade)
Details
Cluster cleanup (helm)
Details
Docker deploy
Details
Cloud integration tests
Details
Cloud cleanup
Details
DCO DCO
Details

2.6 - Release automation moved this from Reviewer approved to Done Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
You can’t perform that action at this time.