Create Helm repos for linkerd2 stable and edge #502
Conversation
This adds the Helm repos `https://run.linkerd.io/edge` and `https://run.linkerd.io/stable`. So the user would install the stable chart with: ```bash helm repo add linkerd-stable https://run.linkerd.io/stable helm install --set blah blah linkerd-stable/linkerd2 ``` So the user would install the edge chart with: ```bash helm repo add linkerd-edge https://run.linkerd.io/edge helm install --set blah blah linkerd-edge/linkerd2 ``` Both repos can coexist in the same Helm environment. I've updated the `install-helm.md` doc accordingly. The `index.yaml` and `linkerd2-0.1.0.tgz` files were generated with the `bin/helm -stable|edge` command added in linkerd/linkerd#3292 Signed-off-by: Alejandro Pedraza Borrero <alejandro@buoyant.io>
| "https://events.linuxfoundation.org/events/servicemeshcon-2019/program/call-for-proposals-cfp/") |
There was a problem hiding this comment.
These CFPs are closed, so do we need to add this?
There was a problem hiding this comment.
The change consisted just on adding a newline at the end of the file to make the linter pass. As for leaving that file, I guess we'd like to leave everything there for historical purposes, but I could be wrong.
There was a problem hiding this comment.
Probably want to remove this, but it should be done in a separate PR.
|
Combining what I gathered from https://github.com/BuoyantIO/buoyant-internal/pull/1023, linkerd/linkerd2#3292 and this PR, my understanding is that we are publishing the chart TL;DR:
Some details on chart publication and user's install/upgrade workflow: The reason behind the proposal to publish only one chart for the edge is because I don't want try to figure out which edge release does chart E.g., during edge release, we modified the I imagine this is what the user's workflow will look like: As for stable releases, how about we make the chart version the same as the release itself? I find the default chart versioning scheme of 0.0.1, 0.0.2 etc. meaningless. On the user's side: |
|
@ihcsim Regarding edge charts, I'm a little uneasy about having the same chart version not being deterministic about what linkerd version it corresponds to, plus we wouldn't have an archive of past charts. If a user reports a problem with a chart then we'd have to re-generate it. Also it seems that wouldn't play well with Helm hub where each chart version gets its own page, for example: That being said, we could indeed have the chart version match the app version, with some minor changes to make it semver. |
|
Per post stand-up convo, we will publish the chart for every edge and stable release, to a new GCS bucket. We will automate this by adding the |
Ref linkerd/website#502 Adds a new final step into `workflow.yml` to generate and push the Helm artifacts. This depends on the changes made to `bin/helm-build` in #3292 so this branch is based on that one till it gets merged. Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Signed-off-by: Alejandro Pedraza Borrero <alejandro@buoyant.io>
There was a problem hiding this comment.
LGTM! Per nits in linkerd/linkerd2#3292, can we call the repo either linkerd, linkerd.io, or helm.linkerd.io, instead of linkerd-stable?
Signed-off-by: Alejandro Pedraza Borrero <alejandro@buoyant.io>
Signed-off-by: Alejandro Pedraza Borrero <alejandro@buoyant.io>
| "https://events.linuxfoundation.org/events/servicemeshcon-2019/program/call-for-proposals-cfp/") |
There was a problem hiding this comment.
Probably want to remove this, but it should be done in a separate PR.
Fixes linkerd/linkerd2#3365
This adds the Helm repos
https://run.linkerd.io/edgeandhttps://run.linkerd.io/stable.So the user would install the stable chart with:
and the edge chart with:
Both repos can coexist in the same Helm environment.
I've updated the
install-helm.mddoc accordingly.The
index.yamlandlinkerd2-0.1.0.tgzfiles were generated with thebin/helm -stable|edgecommand added in linkerd/linkerd2#3292