Add chart_deploy into workflow.yml #3415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added missing OWNERS and README files - Added maintainers section to Chart.yaml - Changed NOTES.txt so it points to the installation of the CLI - Set the proxy-init version to v1.1.0 in values.yaml Ref #3256 Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
… the Identity.Issuer.CrtExpiryAnnotation value Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Changed `bin/helm-build`'s `(-stable|-edge)` flag to `deploy`. It will automatically extract the repo (edge or stable) and version from git. Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Ref linkerd/website#502 Adds a new final step into `workflow.yml` to generate and push the Helm artifacts. This depends on the changes made to `bin/helm-build` in #3292 so this branch is based on that one till it gets merged. Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
siggy
approved these changes
Sep 10, 2019
There was a problem hiding this comment.
nice! a few nits then shipit. 👍 🚢
also can you update the # Jobs by event type and dependencies: section at the top to include this new job?
also also were you able to test this? if not, you could disable all those if: startsWith(github.ref, 'refs/tags') checks on your job for just one run.
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Closed
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
|
@siggy I could finally test this successfully, by setting a fake tag like |
alpeb
added a commit
that referenced
this pull request
Sep 12, 2019
Followup to #3415 Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
alpeb
added a commit
that referenced
this pull request
Sep 12, 2019
Followup to #3415 Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref linkerd/website#502
Adds a new final step into
workflow.ymlto generate and push the Helmartifacts.
This depends on the changes made to
bin/helm-buildin #3292 so thisbranch is based on that one till it gets merged.