New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude static pods from termination #78

Open

linki opened this issue Apr 10, 2018 · 1 comment

Labels

enhancement help wanted

Owner

linki commented Apr 10, 2018

static pods cannot be killed via the Kubernetes API: https://kubernetes.io/docs/tasks/administer-cluster/static-pod/

Let's ignore them. We could use these annotations to detect what is a static pod:

metadata:
  annotations:
    kubernetes.io/config.hash: 3ffad4b19c937d5bb9cbacadb2f463a1
    kubernetes.io/config.mirror: 3ffad4b19c937d5bb9cbacadb2f463a1
    kubernetes.io/config.seen: 2018-04-09T07:44:01.286945749Z
    kubernetes.io/config.source: file

The text was updated successfully, but these errors were encountered:

linki added enhancement help wanted labels

Owner Author

linki commented Jun 6, 2018

Detection could be similar to: https://github.com/zalando-incubator/cluster-lifecycle-manager/blob/8042e37ad3fb482879112e8bc6d095c01ff2ef7c/pkg/updatestrategy/node_pool_manager.go#L481-L484

linki mentioned this issue

Don't try to kill Pods that are not Running #123

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment