Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern is not emitted in the JSON representation of a model #193

Closed
hsolbrig opened this issue Apr 30, 2021 · 2 comments · Fixed by #242
Closed

Pattern is not emitted in the JSON representation of a model #193

hsolbrig opened this issue Apr 30, 2021 · 2 comments · Fixed by #242
Assignees

Comments

@hsolbrig
Copy link
Contributor

No description provided.

@wdduncan
Copy link
Contributor

Adding an example:

slots:
  has function:
      pattern: KEGG:.+

should produce jsonschema like:

"properties": {
        "has_function": {
          "type": "string",
          "pattern": "^KEGG:.+"
        },

Question: Will the slot patterns override the id_prefixes discussed in #194

@cmungall
Copy link
Member

cmungall commented May 3, 2021

Yes, I think slot patterns should override the pattern generated by id_prefixes. Ideally we would have a check that the slot pattern is more restrictive but I am not sure we can auto-detect subsumption, at least not until we decide which flavor of regexes we will support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants