-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide regular expression values for slots' pattern
s
#9
Comments
We could bikeshed about regexes all day. I think these are generally good compromises in terms of complexity and restrictiveness. There are other sorts of strings we could pattern match as well, such as dates, attributes with units, etc. but I think these things are better left to the parsers doing the normalization. DOI:
URL:
The following come from https://microbiomedata.github.io/nmdc-metadata/identifiers/: KO term:
@jeffbaumes You had noted the desire to make this just ENVO term (all the terms I have in my database contain at least 7 digits):
ID's in general
One thing about the |
Thanks @jbeezley. Happy for it to be |
wrt dates - JSON Schema has a date-time which validates to RFC 3339 - so I don't believe we need to apply our own regex to dates. https://json-schema.org/draft/2020-12/json-schema-validation.html#rfc.section.7.3.1 (date-time has been in JSON Schema longer than this draft, I think the date and time are added in JSON Schema 7) |
Update: |
patterns
This issue is closed by the presence of https://linkml.io/linkml-model/docs/pattern/ in the LinkML metamodel, although I do recommend more pattern bikeshedding! |
patterns
pattern
s
Add WorkflowChain class and valid data example
Need a list of regexs to check data.
The text was updated successfully, but these errors were encountered: