Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dependency 'ms' in new applications created using 0.6.5 #754

Closed
kumorig opened this issue Aug 25, 2014 · 3 comments
Closed

Missing dependency 'ms' in new applications created using 0.6.5 #754

kumorig opened this issue Aug 25, 2014 · 3 comments

Comments

@kumorig
Copy link
Contributor

kumorig commented Aug 25, 2014

Creating a new app from scratch using meanio 0.6.5. (quite the version jump here?) produces this file: /var/projects/test/node_modules/serve-favicon/index.js, with this line:

var ms = require('ms');

But this module is missing and will result in the following error:

Mean app started on port 3000 (development)
/var/projects/test/node_modules/meanio/node_modules/q/q.js:126
                throw e;
                      ^
Error: Cannot find module 'ms'
    at Function.Module._resolveFilename (module.js:331:15)
    at Function.Module._load (module.js:273:25)
    at Module.require (module.js:357:17)
    at require (module.js:373:17)
    at Object.<anonymous> (/var/projects/test/node_modules/serve-favicon/index.js:16:10)
    at Module._compile (module.js:449:26)
    at Object.Module._extensions..js (module.js:467:10)
    at Module.load (module.js:349:32)
    at Function.Module._load (module.js:305:12)
    at Module.require (module.js:357:17)
    at require (module.js:373:17)
    at Object.<anonymous> (/var/projects/test/packages/system/app.js:7:13)

It can be solved with npm install ms but I suppose it should be included in package.json from the start.

@pratik60
Copy link
Member

Why don't you submit it as a pull request in meanio repo? I'm sure they'd be happy to merge if that's the case

@kumorig
Copy link
Contributor Author

kumorig commented Aug 25, 2014

Alright, I tried it out. #756 This github stuff is black magic as far as I'm concerned.

Edit: Wrong repo? Hmm. This works at least... Black magic I tell you.

@kumorig kumorig changed the title Missing dependency in new applications created using 0.6.5 Missing dependency 'ms' in new applications created using 0.6.5 Aug 25, 2014
@ellman
Copy link
Collaborator

ellman commented Aug 25, 2014

Adding dependency to package.json @liorkesos we need to review this

85071de92322

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants