Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snyk@1.24.1 breaks build 🚨 #1740

Closed
wants to merge 1 commit into from

Conversation

greenkeeperio-bot
Copy link
Contributor

Hello lovely humans,

snyk just published its new version 1.24.1.

State Failing tests 🚨
Dependency snyk
New version 1.24.1
Type dependency

This version is covered by your current version range and after updating it in your project the build went from success to failure.

As snyk is a direct dependency of this project this is very likely breaking your project right now. If other packages depend on you it’s very likely also breaking them.
I recommend you give this issue a very high priority. I’m sure you can resolve this 💪

Of course this could just be a false positive, caused by a flaky test suite, or third parties that are currently broken or unavailable, but that would be another problem I’d recommend working on.

Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?

There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.

Good luck with your project ✨

You rock!

🌴


GitHub Release

1.24.1 (2017-01-12)

Bug Fixes

  • require authentication when running snyk.test module directly (6d0e770a)

The new version differs by 66 commits .

  • 6d0e770 fix: require authentication when running snyk.test module directly
  • d6d2d53 feat: require authentication for tests
  • 913b7c0 chore: package manager analytics
  • 06de370 test: improve maven exec testing
  • 7c2aa8c fix: rename lib/test to lib/snyk-test
  • de1ad50 fix: adding the 'from' array to dependencies in maven (#157)
  • dbcdc94 fix: maven deps as object for sub modules
  • dfbf1a4 fix: maven dependencies are sent as object; package name is only groupId and artifactId
  • 11c8b6f fix: handle local file missing
  • 0897a58 fix: pass options to monitor
  • 0f517fa feat: alpha support for Maven test and monitor (opt-in)
  • 6b6854c feat: authenticate snyk test
  • defe9b1 fix: wizard package manager fix
  • a5c1b08 test: fix path related assertions for windows
  • f67d324 chore: replace node-uuid with uuid

There are 66 commits in total. See the full diff.


This pull request was created by greenkeeper.io.

Tired of seeing this sponsor message? âš¡ greenkeeper upgrade

@joshje
Copy link

joshje commented Jan 12, 2017

Hi @timelf123, @liorkesos and everyone else at team linnovate!

We now require authentication in order to run snyk test, and your build script doesn't currently authenticate.

Please authenticate by running snyk auth $SNYK_API_KEY before snyk test. You can find your API key by at https://snyk.io/account.

With build tools like Travis, we suggest storing the API key in an environment variable. Here's an example .tavis.yml which runs snyk auth before running tests:
https://github.com/Snyk/snyk/blob/master/.travis.yml#L16

@joshje
Copy link

joshje commented Jan 12, 2017

On further investigation it looks like it's the snyk protect command that is failing, and this should not depend on authentication. We're now releasing a fix for this issue, I'll let you know when it's released.

@joshje
Copy link

joshje commented Jan 12, 2017

Hi @timelf123, @liorkesos

Thanks for bearing with us, we've now resolved the issue. Please re-run your builds and you should see them pass!

@timelf123 timelf123 closed this Feb 4, 2017
@oritpersik oritpersik deleted the greenkeeper-snyk-1.24.1 branch June 20, 2017 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants