Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement routes refactor #235

Closed

Conversation

lirantal
Copy link
Contributor

Avoiding the bloat in routes.js and making it modular, similar to the models loading.
Route middlewares can be placed in app/routes/middlewares directory.

@fyockm
Copy link
Contributor

fyockm commented Jan 16, 2014

+1

@liorkesos
Copy link
Member

Hi Liran,
The routes has some errors from the jshint,
Please cleanup and resubmit...
Lior

@lirantal
Copy link
Contributor Author

hey @liorkesos thanks for letting me know, I missed those.
let's close this pull request as I've issued a new one which is sourcing from my master branch, where I already have this new code working already for my own app too.

So close this one and please review+merge the new pull request: #241

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants