Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facilitate teams with ExternalSecrets and Vault #317

Closed
j-zimnowoda opened this issue Feb 8, 2021 · 9 comments
Closed

Facilitate teams with ExternalSecrets and Vault #317

j-zimnowoda opened this issue Feb 8, 2021 · 9 comments
Assignees
Labels
Task Scrum task

Comments

@j-zimnowoda
Copy link
Contributor

j-zimnowoda commented Feb 8, 2021

**Is your feature request related to a problem?
Teams can define ExternalSecrets CR that fetches values from Vault service.
The ExternalSecrets are cluster wise.

Describe the solution you'd like
See discussion: https://github.com/redkubes/otomi-core/discussions/279

Describe alternatives you've considered
See discussion: https://github.com/redkubes/otomi-core/discussions/279

@j-zimnowoda j-zimnowoda added enhancement New feature or request Story Scrum story labels Feb 8, 2021
@j-zimnowoda j-zimnowoda self-assigned this Feb 8, 2021
@j-zimnowoda
Copy link
Contributor Author

Outcomes from demo:

  1. teams should only be able to deploy ExternalSecrets that points to a specific vault path
  2. the dataFrom property is not needed right now

Ad1) check possible solutions: ExternalSecrets Scoping accessvsOPA policies`

@0-sv
Copy link
Contributor

0-sv commented Feb 22, 2021

We updated the story template: https://github.com/redkubes/unassigned-issues/blob/master/.github/ISSUE_TEMPLATE/user-story.md.

I don't know if it is beneficial, it should be helpful for a developer. If it's not, I'm eager to hear your feedback.

I'm a bit confused, because this looks like a feature request, but it's a story apparently.

@Morriz
Copy link
Contributor

Morriz commented Feb 24, 2021

Yeah, can you fix that @j-zimnowoda ? Please use the story template and use it correctly, as it holds process checkpoints.

@j-zimnowoda
Copy link
Contributor Author

Please, do it if you have time for that

@j-zimnowoda
Copy link
Contributor Author

We updated the story template: https://github.com/redkubes/unassigned-issues/blob/master/.github/ISSUE_TEMPLATE/user-story.md.

I don't know if it is beneficial, it should be helpful for a developer. If it's not, I'm eager to hear your feedback.

I'm a bit confused, because this looks like a feature request, but it's a story apparently.

You are confused by format but do you understand the content ?

@0-sv
Copy link
Contributor

0-sv commented Feb 25, 2021

You are confused by format but do you understand the content ?

That's correct. But the idea of the template is also to gain insight into whether the work to be done is sufficiently defined to reduce scope (personally, I need it to avoid going back and forth with the PO role). And also whether the work done has all the contextual conditions (tests written, documentation updated, etc.) as a sanity-check.

Using the feature request template reduces the consistency of the product backlog.

@Morriz
Copy link
Contributor

Morriz commented Mar 1, 2021

Yeah, we don't ask just because...it really holds an entire checklist that needs to be ticked off

@j-zimnowoda j-zimnowoda changed the title A user can define external-secret in values repo Facilitate teams with ExternalSecrets and Vault Mar 3, 2021
@j-zimnowoda j-zimnowoda added Task Scrum task and removed Story Scrum story enhancement New feature or request labels Mar 3, 2021
@Morriz
Copy link
Contributor

Morriz commented Mar 8, 2021

It is still not clear why this issue exists @j-zimnowoda ? What should be the outcome of this?

@Morriz Morriz closed this as completed Mar 8, 2021
@j-zimnowoda
Copy link
Contributor Author

The story defines the outcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Task Scrum task
Projects
None yet
Development

No branches or pull requests

3 participants