upcoming: [M3-7609] - Placement Groups Landing Page #10068
Conversation
| bottom: -2, | ||
| left: 52, | ||
| position: 'absolute', | ||
| }, |
There was a problem hiding this comment.
This is to position the beta chip similarly to AGLB menu item since this one also wraps in two lines a bit awkwardly
There was a problem hiding this comment.
Nice, I had noticed this before our huddle yesterday.
There was a problem hiding this comment.
This is all pretty boilerplate and subject to iterations as we build this feature
abailly-akamai
requested review from
jdamore-linode and
jaalah-akamai
and removed request for
a team
|
Coverage Report: ✅ |
packages/manager/src/features/PlacementGroups/PlacementGroupsLanding/PlacementGroupsLanding.tsx
Show resolved
Hide resolved
packages/manager/src/features/PlacementGroups/PlacementGroupsLanding/PlacementGroupsLanding.tsx
Show resolved
Hide resolved
|
Tests look good ✅
|
...ages/manager/src/features/PlacementGroups/PlacementGroupsLanding/PlacementGroupsRow.test.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/PlacementGroups/PlacementGroupsLanding/PlacementGroupsRow.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/PlacementGroups/PlacementGroupsLanding/PlacementGroupsRow.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/PlacementGroups/PlacementGroupsLanding/PlacementGroupsRow.tsx
Outdated
Show resolved
Hide resolved
| <Link | ||
| data-testid={`link-to-placement-group-${id}`} | ||
| to={`/placement-groups/${id}`} | ||
| > | ||
| {label} ({affinityType}) | ||
| </Link> |
There was a problem hiding this comment.
Should we push UX to allow us to put affinity_type in its own column? We have plenty of room and this would allow users to order by affinity_type (and maybe filter/seach when we improve our tables)
This also deviates from our normal pattern of keeping the label basic (with no extra information)
There was a problem hiding this comment.
That's a good suggestion, but prob not for M1. Couple reasons:
- The PG label with the affinity appendage will follow you around (it will also be in the PG select, breadcrumb etc). It adds consistency.
- (for now) the sorting is a bit superfluous considering you only get a max of 5 PGs per account
It might be something we do in the future however as the feature evolves
There was a problem hiding this comment.
I had the same question, thanks for asking and clarifying. 👍
Description 📝
This PR adds core elements for the Placement Group feature, namely basic navigation and a populated landing page
Changes 🔄
Preview 📷
How to test 🧪
Prerequisites
Verification steps
Placement Groupsflag and MSWAs an Author I have considered 🤔
Check all that apply