upcoming: [M3-7608]: Placement Groups Landing page empty state #10075
Conversation
carrillo-erik
requested review from
dwiley-akamai and
abailly-akamai
and removed request for
a team
| }; | ||
|
|
||
| export const gettingStartedGuides: ResourcesLinkSection = { | ||
| links: [ |
There was a problem hiding this comment.
The mock ups do not show the typical resource section for empty state. I'm going to post on the project slack channel for insight on future plans. For now, the fields were set to empty strings.
|
This PR is dependent on this PR. In order to commit my changes in the current state, I had to bypass the husky pre-commit hook. Changes will need to be verified before merging this PR. |
There was a problem hiding this comment.
You can just delete that - we can test your component as a stand-alone manually or wait for dependent PR to be merged
There was a problem hiding this comment.
You don't really need a .tsx extension if you don't have and JSX in there - can just use .ts
|
|
||
| export const headers: ResourcesHeaders = { | ||
| description: | ||
| 'Control the physical placement or distribution of virtual machines (VMs) instances within a data center or availability zone.', |
There was a problem hiding this comment.
Is this final copy? "[...] virtual machines (VMs) instances" sounds a bit odd to me. I think it'd sound better either removing "instances" or changing "machines" --> "machine" (& "VMs" --> "VM")
There was a problem hiding this comment.
We're onboarding a tech writer this week and we'll a lot of copy updates to address
|
Coverage Report: ✅ |
| to: '', | ||
| }, | ||
| title: '', | ||
| }; |
There was a problem hiding this comment.
please add TODO VM_Placement comments where needed
Description 📝
Empty state UI on the landing page for the upcoming Placement Groups feature.
Changes 🔄
Preview 📷
How to test 🧪
Prerequisites
serverHandlers.tsfile and change line no. 1875 as follows:return res(ctx.json(makeResourcePage(placementGroupFactory.buildList(0))));Verification steps
yarn test path/to/cloud-manager/manager/packages/manager/src/features/PlacementGroups/PlacementGroupsLanding/PlacementGroupsLanding.test.tsxAs an Author I have considered 🤔