fix: [M3-7746] - Fix $0 region price error in "Enable All Backups" drawer #10161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdamore-linode
requested review from
cliu-akamai,
bnussman-akamai and
jaalah-akamai
and removed request for
a team
jdamore-linode
commented
Feb 7, 2024
| getMonthlyBackupsPrice({ | ||
| region: linode.region, | ||
| type, | ||
| }) || undefined; |
There was a problem hiding this comment.
This || undefined caused monthly prices of 0 to get returned as undefined here
12 tasks
jdamore-linode
changed the title
bnussman-akamai
approved these changes
Feb 7, 2024
jdamore-linode
added
Add'tl Approval Needed
|
Coverage Report: ✅ |
mjac0bs
reviewed
Feb 7, 2024
There was a problem hiding this comment.
I saw a case where the total wasn't be displayed as expected if the totalBackupsPrice is 0 in BackupDrawer.tsx.
If we remove the check for totalBackupsPrice and just go with:
price={
isNumber(totalBackupsPrice) ? totalBackupsPrice : UNKNOWN_PRICE
}
we do see $0 for a total.
| Before | After |
|---|---|
 |
 |
Oh awesome catch, thanks @mjac0bs! I think this even warrants its own test case, so I'll handle that all at once tomorrow. Also totally agreed on that const name, I'll take care of that too 👍 Thank you! |
|
@mjac0bs Just pushed a fix for that $0 total price issue, as well as some unit tests for the BackupDrawer component |
mjac0bs
approved these changes
Feb 8, 2024
mjac0bs
removed
Add'tl Approval Needed
jdamore-linode
added a commit
to jdamore-linode/manager
that referenced
this pull request
Feb 12, 2024
…awer (linode#10161) * Remove error indicator for Linodes in $0 regions * Fix $0 total price display issue * Cover $0 pricing cases in Cypress backup tests * Add BackupLinodeRow tests to account for error states and $0 regions * Add unit tests for BackupDrawer component
12 tasks
jdamore-linode
added a commit
that referenced
this pull request
Feb 12, 2024
…xes for release (#10177) * fix: [M3-7741] - Hide error notices for $0 regions in Resize Pool and Add a Node Pool drawers (#10157) * Allow -zsh LKE prices without error notices in Resize Pool and Add Pool drawers * Fix loading spinner displaying above what was supposed to be loading * Fix conditional to render notice if either price is invalid * Add test coverage * Added changeset: Hide error notices for /bin/sh regions for LKE Resize and Add Node Pools * Fix changeset wording * Address feedback: use invalid price util * fix: [M3-7746] - Fix $0 region price error in "Enable All Backups" drawer (#10161) * Remove error indicator for Linodes in $0 regions * Fix $0 total price display issue * Cover $0 pricing cases in Cypress backup tests * Add BackupLinodeRow tests to account for error states and $0 regions * Add unit tests for BackupDrawer component * fix: [M3-7747] - Fix Linode Migration dialog hidden $0 price (#10166) * Add unit tests for MigrationPricing component * Accounting for $0 prices in MigrationPricing component * fix: [M3-7739] - Fix error when enabling backups for Linodes in regions with $0 price (#10153) * Fix error when enabling backups for Linodes in regions with $0 price * Add unit tests for EnableBackupsDialog --------- Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com> * Replace "toBeDisabled" with "toHaveAttribute" assertion --------- Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
This was referenced Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
This fixes a couple issues in the "Enable All Backups" drawer when one or more Linodes are in a $0-priced region.
Changes 🔄
List any change relevant to the reviewer.
Preview 📷
Include a screenshot or screen recording of the change
💡 Use
<video src="" />tag when including recordings in table.How to test 🧪
We should be able to rely on the unit tests and Cypress tests to cover this, since getting the "Enable All Linode Backups" drawer to appear can be difficult depending on the state of your account.
As an Author I have considered 🤔
Check all that apply