fix: [M3-7747] - Fix Linode Migration dialog hidden $0 price #10166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdamore-linode
requested review from
bnussman-akamai,
jaalah-akamai and
mjac0bs
and removed request for
a team
|
Coverage Report: ✅ |
bnussman-akamai
approved these changes
Feb 8, 2024
bnussman-akamai
added
Add'tl Approval Needed
mjac0bs
approved these changes
Feb 8, 2024
packages/manager/src/features/Linodes/MigrateLinode/MigrationPricing.test.tsx
Outdated
Show resolved
Hide resolved
mjac0bs
added
Approved
jdamore-linode
added a commit
to jdamore-linode/manager
that referenced
this pull request
Feb 12, 2024
…10166) * Add unit tests for MigrationPricing component * Accounting for $0 prices in MigrationPricing component
12 tasks
jdamore-linode
added a commit
that referenced
this pull request
Feb 12, 2024
…xes for release (#10177) * fix: [M3-7741] - Hide error notices for $0 regions in Resize Pool and Add a Node Pool drawers (#10157) * Allow -zsh LKE prices without error notices in Resize Pool and Add Pool drawers * Fix loading spinner displaying above what was supposed to be loading * Fix conditional to render notice if either price is invalid * Add test coverage * Added changeset: Hide error notices for /bin/sh regions for LKE Resize and Add Node Pools * Fix changeset wording * Address feedback: use invalid price util * fix: [M3-7746] - Fix $0 region price error in "Enable All Backups" drawer (#10161) * Remove error indicator for Linodes in $0 regions * Fix $0 total price display issue * Cover $0 pricing cases in Cypress backup tests * Add BackupLinodeRow tests to account for error states and $0 regions * Add unit tests for BackupDrawer component * fix: [M3-7747] - Fix Linode Migration dialog hidden $0 price (#10166) * Add unit tests for MigrationPricing component * Accounting for $0 prices in MigrationPricing component * fix: [M3-7739] - Fix error when enabling backups for Linodes in regions with $0 price (#10153) * Fix error when enabling backups for Linodes in regions with $0 price * Add unit tests for EnableBackupsDialog --------- Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com> * Replace "toBeDisabled" with "toHaveAttribute" assertion --------- Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
This was referenced Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
When migrating to or from a region with $0 pricing, the Linode migrate dialog hides the $0.00 price. This fixes the issue and adds some unit tests.
Changes 🔄
List any change relevant to the reviewer.
Preview 📷
How to test 🧪
To run the new unit tests:
yarn test MigrationPricing.testTo run related Cypress tests:
yarn && yarn build && yarn start:manager:ciand thenyarn cy:run -s "cypress/e2e/core/firewalls/migrate-linode-with-firewall.spec.ts,cypress/e2e/core/linodes/migrate-linode.spec.ts"Manual verification:
Using an account with access to
es-mad, create a Linode ines-mad, wait for it to provision and boot, and then open the Migration dialog (via either the Linode landing page or details page). Confirm that after selecting a new region, the $0 price is displayed for Madrid.Similarly, you can create a Linode in another region, open the Migration dialog, select Madrid for the new region, and confirm that $0 appears.
As an Author I have considered 🤔
Check all that apply