-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: [M3-7500] - Add tests for Parent/Child Users & Grants page enhancements #10240
Conversation
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cassie, thanks for tackling this and moving some of the tests around.
I realized our ticket for M3-7500 was not completely accurate, which means we'll need some changes for how we're checking the Child Account Access column. Comments inline, but let me know if you have any questions!
packages/manager/cypress/e2e/core/account/users-landing-page.spec.ts
Outdated
Show resolved
Hide resolved
packages/manager/cypress/e2e/core/account/users-landing-page.spec.ts
Outdated
Show resolved
Hide resolved
packages/manager/cypress/e2e/core/account/users-landing-page.spec.ts
Outdated
Show resolved
Hide resolved
packages/manager/cypress/e2e/core/account/users-landing-page.spec.ts
Outdated
Show resolved
Hide resolved
packages/manager/cypress/e2e/core/account/users-landing-page.spec.ts
Outdated
Show resolved
Hide resolved
packages/manager/cypress/e2e/core/account/users-landing-page.spec.ts
Outdated
Show resolved
Hide resolved
601c5dd
to
c6537f9
Compare
packages/manager/cypress/e2e/core/account/users-landing-page.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took another pass at this. Our mocks and test cases aren't reflective of what should happen in CM yet, and part of that was likely my misleading comment about the test cases we should cover. My review comments are an attempt to clarify where we have issues now and outline exactly what test cases we need. Lmk if I can help any further, or if something is still confusing -- happy to help.
packages/manager/cypress/e2e/core/account/users-landing-page.spec.ts
Outdated
Show resolved
Hide resolved
packages/manager/cypress/e2e/core/account/users-landing-page.spec.ts
Outdated
Show resolved
Hide resolved
packages/manager/cypress/e2e/core/account/users-landing-page.spec.ts
Outdated
Show resolved
Hide resolved
packages/manager/cypress/e2e/core/account/users-landing-page.spec.ts
Outdated
Show resolved
Hide resolved
packages/manager/cypress/e2e/core/account/users-landing-page.spec.ts
Outdated
Show resolved
Hide resolved
packages/manager/cypress/e2e/core/account/users-landing-page.spec.ts
Outdated
Show resolved
Hide resolved
Can we merge in develop / rebase this PR with develop? I think the Notistack/Snackbar changes might affect these tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing feedback. These test cases look accurate now and all are passing on my local runs! I didn't notice any snackbar impact, so I don't think the Notistack update affected things here, but @bnussman-akamai knows more about that than me.
Remaining changes:
- Can we add the test cases that were removed (because they didn't belong on the user landing test spec, since they were part of the user permissions page) to the
user-permissions.spec.ts
? I left my earlier comments that were about this unresolved and resolved everything else that has been addressed. - Clean up for couple of minor comment updates for clarity/typo fixes
packages/manager/cypress/e2e/core/account/users-landing-page.spec.ts
Outdated
Show resolved
Hide resolved
packages/manager/cypress/e2e/core/account/users-landing-page.spec.ts
Outdated
Show resolved
Hide resolved
packages/manager/cypress/e2e/core/account/users-landing-page.spec.ts
Outdated
Show resolved
Hide resolved
packages/manager/cypress/e2e/core/account/users-landing-page.spec.ts
Outdated
Show resolved
Hide resolved
packages/manager/cypress/e2e/core/account/users-landing-page.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some clean up in 21fe358 to further separate our testing in the Users & Grants landing and User Permissions pages, and avoid duplicating test coverage.
This looks good to me now; both tests passed locally, so as long as all looks good with CI, we can merge this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cliu-akamai and @mjac0bs!
Description 📝
Add regression tests to check enhancements in users landing page.
Major Changes 🔄
How to test 🧪