Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [M3-7909] - Hide the Child Account Access table header for parent users without child_account_access grant #10305

Conversation

mjac0bs
Copy link
Contributor

@mjac0bs mjac0bs commented Mar 21, 2024

Description πŸ“

We should make a UI change to only display the Child Account Access column for users with the child_account_access grant enabled.

This is a place where we missed the grant check for a restricted parent. Since this is a restricted user they won’t ever see anything more than that column header without Full Account Access, so this is minor. But, to maintain consistency, a restricted parent user without the child account access grant should not see any UI features related to Parent/Child.

Changes πŸ”„

  • Adds a grant check for child_account_access to determine whether to display the Child Account Access column header

Target release date πŸ—“οΈ

4/1/24

Preview πŸ“·

Before After
Current NoGrant WithGrant

How to test πŸ§ͺ

Prerequisites

(How to setup test environment)

  • Use the shared Cloud Manager parent and restricted parent test accounts.
  • The restricted-parent-cloud-manager should have child_account_access disabled initially.

Reproduction steps

(How to reproduce the issue, if applicable)

  • Log into dev with the restricted parent account credentials.
  • Go to https://cloud.dev.linode.com/account/users.
  • Observe that although the table displays no data for a restricted user, you can still see the "Child Account Access" column in the table header.

Verification steps

(How to verify changes)

As an Author I have considered πŸ€”

Check all that apply

  • πŸ‘€ Doing a self review
  • ❔ Our contribution guidelines
  • 🀏 Splitting feature into small PRs
  • βž• Adding a changeset
  • πŸ§ͺ Providing/Improving test coverage
  • πŸ” Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • πŸ‘£ Providing comprehensive reproduction steps
  • πŸ“‘ Providing or updating our documentation
  • πŸ•› Scheduling a pair reviewing session
  • πŸ“± Providing mobile support
  • β™Ώ Providing accessibility support

@mjac0bs mjac0bs requested a review from a team as a code owner March 21, 2024 22:10
@mjac0bs mjac0bs requested review from cpathipa and abailly-akamai and removed request for a team March 21, 2024 22:10
@mjac0bs mjac0bs self-assigned this Mar 21, 2024
@mjac0bs mjac0bs changed the title fix: [M3-7797] - Hide the Child Account Access table header for parent users without child_account_access grant fix: [M3-7909] - Hide the Child Account Access table header for parent users without child_account_access grant Mar 21, 2024
Copy link

github-actions bot commented Mar 21, 2024

Coverage Report: βœ…
Base Coverage: 81.64%
Current Coverage: 81.64%

Copy link
Contributor

@jaalah-akamai jaalah-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚒

@jaalah-akamai jaalah-akamai added the Add'tl Approval Needed Waiting on another approval! label Mar 22, 2024
@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Mar 22, 2024
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev is broken so I can test but approving in good faith since the PR looks good 🚒

@mjac0bs mjac0bs merged commit abaf03c into linode:develop Mar 22, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Parent / Child Account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants