fix: [M3-7880] - Properly reset rebuild modal state #10287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly-akamai
commented
Mar 14, 2024
|
|
||
| const handleRebuildError = (status: string) => { | ||
| setRebuildError(status); | ||
| }; | ||
|
|
||
| return ( | ||
| <Dialog | ||
| TransitionProps={{ onExited: onExitDrawer }} |
There was a problem hiding this comment.
We could frankly stop reseting state with useEffect all together on modal/drawer by resetting it via onClose and TransitionProps
I used TransitionProps here to prevent a DOM change before the modal has closed, which is a nice bonus (you could maybe see the content very briefly otherwise)
| data-qa-rebuild-desc | ||
| sx={{ paddingBottom: theme.spacing(2) }} |
There was a problem hiding this comment.
just alpha ordering - no other change
abailly-akamai
requested review from
carrillo-erik and
jaalah-akamai
and removed request for
a team
abailly-akamai
changed the title
jaalah-akamai
approved these changes
Mar 14, 2024
cpathipa
approved these changes
Mar 14, 2024
carrillo-erik
approved these changes
Mar 14, 2024
|
Coverage Report: ✅ |
This was referenced Mar 18, 2024
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR fixes a bug where the "mode" state of the rebuild dialog wasn't reset when mounted. This isn't as bad a bug as initially thought, just a potential awkward experience for the user.
Changes 🔄
Target release date 🗓️
3/18/2024
Preview 📷
Screen.Recording.2024-03-14.at.16.24.33.mov
Screen.Recording.2024-03-14.at.16.22.19.mov
How to test 🧪
Reproduction steps
Navigate to linode list, click on "Rebuild" action menu item for Linode A
Close modal, click on "Rebuild" action menu item for Linode A
Navigate to linode list, click on "Rebuild" action menu item for Linode A
Close modal, click on "Rebuild" action menu item for Linode B
Verification steps
Navigate to linode list, click on "Rebuild" action menu item for Linode A
Close modal, click on "Rebuild" action menu item for Linode A
Navigate to linode list, click on "Rebuild" action menu item for Linode A
Close modal, click on "Rebuild" action menu item for Linode B
As an Author I have considered 🤔
Check all that apply