Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcoming: [M3-7903] - Placement Groups: Edit Drawer & Delete Modal UI Updates #10312

Merged
merged 10 commits into from
Mar 26, 2024

Conversation

abailly-akamai
Copy link
Contributor

@abailly-akamai abailly-akamai commented Mar 25, 2024

Description πŸ“

This PR brings UI improvements to both the PG Edit Drawer & Delete Modal. Now that the feature is in ALPHA, it is easier to implement the right patterns (loading, error handling) to both these flows.

Changes πŸ”„

  • Add new onExited optional prop to Dialog and Drawer in order to reset state/data when closing animation completes (see fix: [M3-7880] - Properly reset rebuild modal stateΒ #10287 and cafe item for reference)
  • Delete Modal:
    • Notice: remove second bullet point notice (turn it into regular notice (no bullet) when no linode is attached) & remove linode list, only keep type to confirm when no linode is attached
    • Improve error and loading patterns
  • Edit Drawer
    • Improve error and loading patterns

Preview πŸ“·

Delete Modal Edit Drawer
Screen.Recording.2024-03-25.at.12.52.36.mov
Screen.Recording.2024-03-25.at.12.50.56.mov

How to test πŸ§ͺ

Prerequisites

  • ⚠️⚠️ have the dev admin placement-group customer tag ⚠️⚠️
  • Switch to the dev API
  • Have the "Placement Group" feature flag on
  • Have MSW off

Verification steps

Delete Modal

  • Click on "Delete" and confirm modal behavior
  • While Dialog open, reload page and confirm behavior
  • While Dialog open, Change URL to a non existing ID, reload page and confirm behavior

Edit Drawer

  • Click on "Edit" and confirm Drawer behavior
  • While Drawer open, reload page and confirm behavior
  • While Drawer open, Change URL to a non existing ID, reload page and confirm behavior

As an Author I have considered πŸ€”

Check all that apply

  • πŸ‘€ Doing a self review
  • ❔ Our contribution guidelines
  • 🀏 Splitting feature into small PRs
  • βž• Adding a changeset
  • πŸ§ͺ Providing/Improving test coverage
  • πŸ” Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • πŸ‘£ Providing comprehensive reproduction steps
  • πŸ“‘ Providing or updating our documentation
  • πŸ•› Scheduling a pair reviewing session
  • πŸ“± Providing mobile support
  • β™Ώ Providing accessibility support

@abailly-akamai abailly-akamai self-assigned this Mar 25, 2024
@abailly-akamai abailly-akamai marked this pull request as ready for review March 25, 2024 16:40
@abailly-akamai abailly-akamai requested a review from a team as a code owner March 25, 2024 16:41
@abailly-akamai abailly-akamai requested review from mjac0bs, jaalah-akamai and carrillo-erik and removed request for a team March 25, 2024 16:41
Copy link

github-actions bot commented Mar 25, 2024

Coverage Report: βœ…
Base Coverage: 81.65%
Current Coverage: 81.67%

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of questions, but handling of loading and error state is looking good over all. Thank you for the tests!

@mjac0bs mjac0bs added the Add'tl Approval Needed Waiting on another approval! label Mar 26, 2024
Copy link
Contributor

@jaalah jaalah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good πŸ‘

@jaalah-akamai jaalah-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Mar 26, 2024
@abailly-akamai abailly-akamai merged commit 860b0bd into linode:develop Mar 26, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Placement Groups
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants