-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [M3-7903] - Placement Groups: Edit Drawer & Delete Modal UI Updates #10312
Conversation
Coverage Report: β
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of questions, but handling of loading and error state is looking good over all. Thank you for the tests!
packages/manager/.changeset/pr-10312-upcoming-features-1711384895230.md
Outdated
Show resolved
Hide resolved
packages/manager/src/features/PlacementGroups/PlacementGroupsDeleteModal.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/PlacementGroups/PlacementGroupsDeleteModal.tsx
Show resolved
Hide resolved
packages/manager/src/features/PlacementGroups/PlacementGroupsEditDrawer.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/PlacementGroups/PlacementGroupsDeleteModal.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good π
Description π
This PR brings UI improvements to both the PG Edit Drawer & Delete Modal. Now that the feature is in ALPHA, it is easier to implement the right patterns (loading, error handling) to both these flows.
Changes π
onExited
optional prop to Dialog and Drawer in order to reset state/data when closing animation completes (see fix: [M3-7880] - Properly reset rebuild modal stateΒ #10287 and cafe item for reference)Preview π·
Screen.Recording.2024-03-25.at.12.52.36.mov
Screen.Recording.2024-03-25.at.12.50.56.mov
How to test π§ͺ
Prerequisites
Verification steps
Delete Modal
Edit Drawer
As an Author I have considered π€
Check all that apply