refactor: [M3-7893] – Post-GA VPC cleanup #10299
Conversation
…lHeader.tsx, useVPCConfigInterface.tsx cleanup
…sDialogOrDrawer.tsx, VPCSubnetsTable.tsx
dwiley-akamai
requested review from
bnussman-akamai and
hana-linode
and removed request for
a team
|
The removal of VPC from |
| {}, | ||
| displayVPCPanel | ||
| ); | ||
| const { data: vpcData, error, isLoading } = useVPCsQuery({}, {}); |
There was a problem hiding this comment.
Unrelated to this PR: If the uses has more the 100 VPCs, only the first 100 will show
There was a problem hiding this comment.
@dwiley-akamai We can probably remove the enabled argument for useVPCsQuery now
There was a problem hiding this comment.
Going to create a ticket for implementing a useAllVPCsQuery where appropriate
| {}, | ||
| displayVPCPanel | ||
| ); | ||
| const { data: vpcData, error, isLoading } = useVPCsQuery({}, {}); |
There was a problem hiding this comment.
@dwiley-akamai We can probably remove the enabled argument for useVPCsQuery now
This is when powering down a linode, right? I can check if there's a backlog ticket already for addressing this (and if not, will create one) |
|
Coverage Report: ❌ |
Description 📝
Since VPC entered GA several weeks back, we are now able to circle back to complete some code cleanup. This ticket is primarily for
@TODO VPCitems related to the VPC feature flag and related conditionals.Changes 🔄
flags.vpc,showVPCs, and related logic throughout many filesmanuallyUpdateConfigsprop fromPowerActionsDialogOrDrawer.tsximport type { ...}convention in a few placesTarget release date 🗓️
04/01/2024
How to test 🧪
Verification steps
Ensure there have been no regressions compared to prod, specifically:
Ctrl+Shift+K"Use Private IP for a backend node to a NodeBalancer. Use VPC instead for private communication between your Linodes."copy is present for Private IP add-onInterfaceSelectworks as expected in Linode Config dialog and VLAN accordionAs an Author I have considered 🤔