Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [M3-7895] – Remove VPC feature flag #10306

Merged

Conversation

dwiley-akamai
Copy link
Contributor

@dwiley-akamai dwiley-akamai commented Mar 22, 2024

Description πŸ“

Following up on #10299, this PR removes the VPC feature flag from featureFlags.ts, removes it from our feature flag DevTool, and cleans up a few unit tests accordingly.

After the next release, the LD flag will be archived.

Target release date πŸ—“οΈ

04/01/2024

How to test πŸ§ͺ

Verification steps

  • InterfaceSelect.test.tsx, LinodeConfigDialog.test.tsx, LinodeEntityDetail.test.tsx should pass
  • VPC should no longer be an option in our feature flag DevTool

As an Author I have considered πŸ€”

  • πŸ‘€ Doing a self review
  • ❔ Our contribution guidelines
  • 🀏 Splitting feature into small PRs
  • βž• Adding a changeset
  • πŸ§ͺ Providing/Improving test coverage
  • πŸ” Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • πŸ‘£ Providing comprehensive reproduction steps
  • πŸ“‘ Providing or updating our documentation
  • πŸ•› Scheduling a pair reviewing session
  • πŸ“± Providing mobile support
  • β™Ώ Providing accessibility support

@dwiley-akamai dwiley-akamai added the VPC Relating to VPC project label Mar 22, 2024
@dwiley-akamai dwiley-akamai self-assigned this Mar 22, 2024
@dwiley-akamai dwiley-akamai requested a review from a team as a code owner March 22, 2024 16:11
@dwiley-akamai dwiley-akamai requested review from jdamore-linode and carrillo-erik and removed request for a team March 22, 2024 16:11
Copy link

github-actions bot commented Mar 22, 2024

Coverage Report: βœ…
Base Coverage: 81.64%
Current Coverage: 81.64%

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

βœ… Tests passed.
Screenshot 2024-03-22 at 10 02 22 AM

βœ… vpc flag is not present in dev tools.
Screenshot 2024-03-22 at 10 02 50 AM

Thanks for the clean up!

@mjac0bs mjac0bs added the Add'tl Approval Needed Waiting on another approval! label Mar 22, 2024
…3.md

Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Mar 22, 2024
@dwiley-akamai dwiley-akamai merged commit fda2aae into linode:develop Mar 22, 2024
18 checks passed
@dwiley-akamai dwiley-akamai deleted the M3-7895-vpc-remove-feature-flag branch March 22, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! VPC Relating to VPC project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants