Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M3-5981: Improve Storybook dev guide #8602

Merged
merged 3 commits into from
Nov 9, 2022

Conversation

mjac0bs
Copy link
Contributor

@mjac0bs mjac0bs commented Nov 8, 2022

Description 📝

What does this PR do?

Updates the repo's development guide with yarn commands for building & starting up an instance of Storybook locally and best practices/tips collected from previous Slack channel lore.

How to test 🧪

What are the steps to reproduce the issue or verify the changes?

  • Read through for any typos or unclear/inaccurate parts.
  • Check that all links are valid.

Copy link
Contributor

@bnussman bnussman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job on this 🚀

@mjac0bs mjac0bs marked this pull request as ready for review November 8, 2022 19:42
Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice additions!

@mjac0bs mjac0bs merged commit 8c76d39 into linode:develop Nov 9, 2022
@mjac0bs mjac0bs self-assigned this Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants