Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(routers): support gitweb such as git.samba.org #149

Merged
merged 38 commits into from
Nov 24, 2023

Conversation

linrongbin16
Copy link
Owner

@linrongbin16 linrongbin16 commented Nov 23, 2023

Regression Test

Platforms

  • windows
  • macOS
  • linux

Tasks

  • Use GitLink to copy git link.
  • Use GitLink! to open git link in browser.
  • Use GitLink blame to copy the /blame git link.
  • Use GitLink! blame to open the /blame git link in browser.
  • Copy git link in a symlink directory of git repo.
  • Copy git link in an un-pushed git branch, and receive an expected error.
  • Copy git link in a pushed git branch but edited file, and receive a warning says the git link could be wrong.

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 48 lines in your changes are missing coverage. Please review.

Comparison is base (dd7fdd1) 75.76% compared to head (55ba1f6) 77.26%.

Files Patch % Lines
lua/gitlinker.lua 68.45% 47 Missing ⚠️
lua/gitlinker/linker.lua 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
+ Coverage   75.76%   77.26%   +1.49%     
==========================================
  Files          11       11              
  Lines         949      994      +45     
==========================================
+ Hits          719      768      +49     
+ Misses        230      226       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@linrongbin16
Copy link
Owner Author

relate: #146

@linrongbin16 linrongbin16 changed the title feat(prioritized route bindings): support list-based prioritized route bindings feat(git.samba.org): support gitweb such as git.samba.org Nov 24, 2023
@linrongbin16 linrongbin16 changed the title feat(git.samba.org): support gitweb such as git.samba.org feat(routers): support gitweb such as git.samba.org Nov 24, 2023
@linrongbin16 linrongbin16 merged commit d1d2482 into master Nov 24, 2023
8 checks passed
@linrongbin16 linrongbin16 deleted the feat-support-git-samba branch November 24, 2023 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant