Keep returning only PAM_IGNORE from pam_motd #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On Sat, Dec 14, 2019 at 02:22:21AM -0800, Balint Reczey wrote:
Follow-up for c81280b.
You can view, comment on, or merge this pull request online at:
#157
I suppose errors returned by pam_putenv shouldn't be ignored.
What do you think about the following fix:
- return retval;
+ return retval == PAM_SUCCESS ? PAM_IGNORE : retval;
|
rbalint
force-pushed
the
master
branch
2 times, most recently
from
d510f22
to
61eb777
Compare
|
OK, I've also updated the man page. |
t8m
requested changes
Dec 17, 2019
modules/pam_motd/pam_motd.8.xml
Outdated
| <term>PAM_ABORT</term> | ||
| <listitem> | ||
| <para> | ||
| Not all relevant data or options could be gotten. |
There was a problem hiding this comment.
got or obtained - although sometimes used gotten is weird.
There was a problem hiding this comment.
I agree. I copied this over from pam_env and the same phrasing is present in other modules, too, thus I did not want to diverge.
Follow-up for c81280b.
t8m
approved these changes
Dec 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for c81280b.