providers/irdma: Validate input before memory window bind #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rleon
reviewed
Dec 15, 2021
providers/irdma/uverbs.c
Outdated
| return EINVAL; | ||
|
|
||
| if (bind_info->mr) { |
There was a problem hiding this comment.
- Why do we need these checks in user-space and not in the driver?
It is preferable to have one place for the checks and drivers are supposed to have these type of checks anyway. - I imagine almost all drivers need these checks. Why irdma is special here?
- You have double SOB for Tatyana in the commit message.
Signed-off-by: Signed-off-by: Tatyana Nikolova tatyana.e.nikolova@intel.com
There was a problem hiding this comment.
- Why do we need these checks in user-space and not in the driver?
It is preferable to have one place for the checks and drivers are supposed to have these type of checks anyway.- I imagine almost all drivers need these checks. Why irdma is special here?
- You have double SOB for Tatyana in the commit message.
Signed-off-by: Signed-off-by: Tatyana Nikolova tatyana.e.nikolova@intel.com
Hi Leon - Thanks for the review. Sindhu is out for the rest of the year. And will work on these review comments when she is back on Jan 4th.
Shiraz
There was a problem hiding this comment.
Bind isn't supposed to call to the kernel, but perhaps the checkes should be done in the core rdma-core code..
There was a problem hiding this comment.
Will send out a patch. Thanks Jason/Leon.
irdma does not do proper input validation checks on the memory window bind. Specifically, the checks for non-null MR, address and length as well as one to ensure MR and MW are in same PD are missing. Fix this by moving these checks to core code and remove it from providers rxe, hns, mlx5 and irdma too. Fixes: 14a0fc8 ("rdma-core/irdma: Implement device supported verb APIs") Signed-off-by: Sindhu-Devale <sindhu.devale@intel.com> Signed-off-by: Tatyana Nikolova <tatyana.e.nikolova@intel.com>
Sindhu-Devale
force-pushed
the
libirdma-12-9-fixes
branch
2 times, most recently
from
67ef6ce
to
a83619b
Compare
|
Looks good, if no one complains, I will merge it tomorrow, before rdma-core release. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for a non null MR, address and length
before allowing bind operation.
Also, add check to make sure the MR and MW are in
same PD before posting a bind MW op.
Fixes: 14a0fc8 ("rdma-core/irdma: Implement device supported verb APIs")
Signed-off-by: Tatyana Nikolova tatyana.e.nikolova@intel.com
Signed-off-by: Sindhu-Devale sindhu.devale@intel.com