redhat/spec: Don't trigger udev if socket doesn't exist #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlebon
changed the title
|
Upstreamed from https://src.fedoraproject.org/rpms/rdma-core/pull-request/6. |
On rpm-ostree systems, we don't want scriptlets to affect the running system because a major part of the value is "background updates". Scriptlets are run in a containerized environment where e.g. udev is not available. Add a check for the udev socket before triggering it to handle this. This also helps the container use case. This doesn't break rpm-ostree strictly, because it uses `|| true`, but it still spams error messages during the compose. I kept the `|| true` to be safe, but it's likely fine to remove them now. See also: https://bugzilla.redhat.com/show_bug.cgi?id=1352154 See also: https://src.fedoraproject.org/rpms/udisks2/pull-request/3 See also: coreos/fedora-coreos-tracker#703 Signed-off-by: Jonathan Lebon <jonathan@jlebon.com>
|
Shouldn't this be handled inside udevadm? Why change every package? Will this go become unnecessary with Honggang's change to dependencies so rdma-core is not pulled into container images in general? |
@jlebon |
Yes, it looks like we're no longer pulling in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On rpm-ostree systems, we don't want scriptlets to affect the running
system because a major part of the value is "background updates".
Scriptlets are run in a containerized environment where e.g. udev is not
available.
Add a check for the udev socket before triggering it to handle this.
This also helps the container use case.
This doesn't break rpm-ostree strictly, because it uses
|| true, butit still spams error messages during the compose. I kept the
|| trueto be safe, but it's likely fine to remove them now.
See also: https://bugzilla.redhat.com/show_bug.cgi?id=1352154
See also: https://src.fedoraproject.org/rpms/udisks2/pull-request/3
See also: coreos/fedora-coreos-tracker#703