Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unmask firewalld on run, disable conflicting services #154

Merged
merged 5 commits into from
Jul 13, 2023

Commits on Jul 12, 2023

  1. fix - unmask firewalld on run, disable conflicting services

    Role will now always attempt to unmask on role run
    
    add variable 'firewall_disable_conflicting_services' to enable the
    disabling of conflicting services
    - Set to false by default
      - Requires that services are enumerated on managed nodes, which can
        introduce potentially unnecessary runtime overhead
    
    Update README to document the following behavior of the system role:
    - linux-system-roles.firewall will attempt to install, unmask, and enable firewalld
    - linux-system-roles.firewall can attempt to disable directly conflicting services to firewalld
      - and that is enabled by setting the variable 'firewall_disable_conflicting_services' to true
      - list of conflicting services present in vars/main.yml
    test cases for these changes in tests/tests_default.yml
    
    Addresses GitHub Issues: linux-system-roles#103, linux-system-roles#136
    BrennanPaciorek committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    b17a74a View commit details
    Browse the repository at this point in the history
  2. docs: change instructions regarding conflicting services

    List out conflicting services checked for in README, move some instruction in the introduction down to relevant variable.
    BrennanPaciorek committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    5d9c98f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6a3d6fb View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. Configuration menu
    Copy the full SHA
    7ec3dd7 View commit details
    Browse the repository at this point in the history
  2. tests - revert tests.yml, move previous contents

    Return tests_default.yml to its original state
    
    Move tests for unmasking firewalld and removing conflicting services to tests_startup_conflicts.yml
    BrennanPaciorek committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    a586d09 View commit details
    Browse the repository at this point in the history