ci: Use supported ansible-lint action; run ansible-lint against the collection #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richm
force-pushed
the
ansible-lint-test-2.16
branch
from
f598dd7
to
36a3c8d
Compare
…ollection The old ansible-community ansible-lint is deprecated. There is a new ansible-lint github action. The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test. This also requires tox-lsr 3.2.1 Role developers can run this locally using `tox -e collection,ansible-lint-collection` See linux-system-roles/tox-lsr#125 Fix ansible-lint and ansible-test issues reported by the latest 2.16 versions. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
force-pushed
the
ansible-lint-test-2.16
branch
from
36a3c8d
to
a25523d
Compare
Jakuje
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
Looks good.
The only issue is in the fedora run, which is caused by different formatting of the manual pages in recent fedora. The fix is already in
https://github.com/willshersystems/ansible-sshd/pull/267/files#diff-be5ce908d6eff907335bb9002a9219ea9c6f57937a36a0bbe7c9448719a258d5
but I can pull it into separate PR if that one is not yet ready.
The debian is likely failing because of missing requirements installation from tests/requirements.yml. I can probably do it in separate PR too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old ansible-community ansible-lint is deprecated. There is a
new ansible-lint github action.
The latest Ansible repo gating tests run ansible-lint against
the collection format instead of against individual roles.
We have to convert the role to collection format before running
ansible-test.
This also requires tox-lsr 3.2.1
Role developers can run this locally using
tox -e collection,ansible-lint-collectionSee linux-system-roles/tox-lsr#125
Fix ansible-lint and ansible-test issues reported by the
latest 2.16 versions.
Signed-off-by: Rich Megginson rmeggins@redhat.com