Annotations improvements

[mickaelalbertus]

• Add an annotation toggle button to show or hide the annotation toolbar
• Move the annotations toolbar from sidebar annotations to a toolbar which appears when the annotation button is toggled.

The following image is what the commit do:

It is the beginning of future possible transformations but I need your opinion. The annotation sidebar should contain all buttons to create every kind of annotations most used. It is inspired by the evince GUI. It could be a good alternative for the GUI suggested in pull request #223. What do you think?

[Piiit]

Hi. I tried to avoid this UI when I did the annotation patches, because most displays give more space in their width I think your first proposal with an annotations side panel looks much better

[Piiit]

I think that the Adobe Acrobat Reader does a quite reasonable job... It would be extensible for annotation lists and predefined sets of configs or any other feature in that regard... It is also a huge waste of space horizontal and vertical IMO...
Cheers,
Peter

[mickaelalbertus]

Here is the new GUI that I suggest. I changed to toolbar into a flow box like the recent view.

What do you think about it?
I didn't do the Acrobat interface since there no basic widget to do that (to my knowledge). The GtkToolPalette can only contain tool button so it wouldn't be possible to add a list view in a gtk palette. So if we realy want the Acrobat interface we need to write from scratch the widget to do that and I'm not sure it would be pretty.

The commit isn't ready enough. It is only an implementation of a suggestion. So if you agree with this kind of interface I can write this feature.

I use Gimp icons and evince icons. It is not pretty but I don't have graphical skills to make pretty icons like those of Evince. If anyone know how can we have other annotation icons?

[clefebvre]

Hi @mickaelalbertus,

Do you still have access to the Slack group? I'd love to help, but I've so many questions and remarks.. I'd rather chat directly than comment on github. We could get piiit to shine in as well.

[mickaelalbertus]

I've pushed the last modification to be able to test it. There is some modifications to add like we talked in Slack. The annotation toolbar (it is not a real toolbar) is complete, we can move the text annotation, change the color of added annotations, etc...
I will add the functionality to save the last chosen color.

[mtwebster]

I'm going to throw my opinion into the ring. 😄

I've never ever liked the buttons at the bottom of the side bar. It's an unnatural location to me. Why can't these buttons all go in the toolbar, and just change whenever the view type is changed in the sidebar? Possibly move the combobox to the toolbar also?

Right now the toolbar is practically empty, there's plenty of room there. (We could do something instead of a combo for selecting views, but it's ok like it is, just not in the best location).

[mickaelalbertus]

We had a discussion about it on Slack. It is a first MVP that we planned but there will have other modifications. In particular we thought to do something like Nemo. A status bar with buttons to show/hide the sidebar and modify the content of the sidebar (see the bottom left of nemo for an example). I think it is good idea to be coherent with nemo and we could put the zoom button (or slider we didn't talk about it). And put the buttons of annotations in the top of the annotation sidebar. If you have ideas about it we can speak on Slack. I would be glad to implement functionalities for xreader like these.