Update LUA version in Dockerfile

[xriser]

The build is failed
https://ci.linuxserver.io/job/Docker-Pipeline-Builders/job/docker-domoticz/job/master/219/console

Need to update LUA package to lua5.3-dev in Dockerfile

[CHBMB]

@tobbenb Bit more info

�[0m-- The C compiler identification is GNU 8.3.0
-- The CXX compiler identification is GNU 8.3.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Failed to get ProjectRevision from git
-- Read ProjectRevision from History.txt
-- ###########################
-- Compiling Revision #xxxxx
-- ###########################
-- Found PkgConfig: /usr/bin/pkg-config (found version "1.6.1") 
-- Checking for one of the modules 'lua5.3>=5.3;lua>=5.3;lua-5.3'
�[91mCMake Error at CMakeLists.txt:93 (MESSAGE):
  LUA not found but USE_BUILTIN_LUA=NO

I've forked master and updated the package, just building it locally and if it's working then I'll submit a PR.

Dunno what you want to do about stable if that also is going to need Lua updating then let me know and I'll submit a PR for that too.

[CHBMB]

@tobbenb

Never used Domoticz but tried updating to lua5.3-dev

As always with this container, it's not as straightforward as it first appears to be. 😁

Build still failed.....

[ 45%] Building CXX object CMakeFiles/domoticz.dir/hardware/MQTT.cpp.o
/tmp/domoticz/hardware/MQTT.cpp: In constructor 'MQTT::MQTT(int, const string&, short unsigned int, const string&, const string&, const string&, int, int)':
/tmp/domoticz/hardware/MQTT.cpp:33:31: warning: 'mosqpp::mosquittopp::mosquittopp(const char*, bool)' is deprecated [-Wdeprecated-declarations]
 mosqpp::mosquittopp("Domoticz")
                               ^
In file included from /tmp/domoticz/hardware/MQTT.h:10,
                 from /tmp/domoticz/hardware/MQTT.cpp:2:
/usr/include/mosquittopp.h:94:14: note: declared here
   DEPRECATED mosquittopp(const char *id=NULL, bool clean_session=true);
              ^~~~~~~~~~~
/tmp/domoticz/hardware/MQTT.cpp:38:10: warning: 'int mosqpp::lib_init()' is deprecated [-Wdeprecated-declarations]
  mosqpp::lib_init();
          ^~~~~~~~
In file included from /tmp/domoticz/hardware/MQTT.h:10,
                 from /tmp/domoticz/hardware/MQTT.cpp:2:
/usr/include/mosquittopp.h:48:30: note: declared here
 mosqpp_EXPORT int DEPRECATED lib_init();
                              ^~~~~~~~
/tmp/domoticz/hardware/MQTT.cpp:38:19: warning: 'int mosqpp::lib_init()' is deprecated [-Wdeprecated-declarations]
  mosqpp::lib_init();
                   ^
In file included from /tmp/domoticz/hardware/MQTT.h:10,
                 from /tmp/domoticz/hardware/MQTT.cpp:2:
/usr/include/mosquittopp.h:48:30: note: declared here
 mosqpp_EXPORT int DEPRECATED lib_init();
                              ^~~~~~~~
/tmp/domoticz/hardware/MQTT.cpp:38:19: warning: 'int mosqpp::lib_init()' is deprecated [-Wdeprecated-declarations]
  mosqpp::lib_init();
                   ^
In file included from /tmp/domoticz/hardware/MQTT.h:10,
                 from /tmp/domoticz/hardware/MQTT.cpp:2:
/usr/include/mosquittopp.h:48:30: note: declared here
 mosqpp_EXPORT int DEPRECATED lib_init();
                              ^~~~~~~~
/tmp/domoticz/hardware/MQTT.cpp:47:19: warning: 'int mosqpp::mosquittopp::threaded_set(bool)' is deprecated [-Wdeprecated-declarations]
  threaded_set(true);
                   ^
In file included from /tmp/domoticz/hardware/MQTT.h:10,
                 from /tmp/domoticz/hardware/MQTT.cpp:2:
/usr/include/mosquittopp.h:130:18: note: declared here
   int DEPRECATED threaded_set(bool threaded=true);
                  ^~~~~~~~~~~~
/tmp/domoticz/hardware/MQTT.cpp: In destructor 'virtual MQTT::~MQTT()':
/tmp/domoticz/hardware/MQTT.cpp:52:10: warning: 'int mosqpp::lib_cleanup()' is deprecated [-Wdeprecated-declarations]
  mosqpp::lib_cleanup();
          ^~~~~~~~~~~
In file included from /tmp/domoticz/hardware/MQTT.h:10,
                 from /tmp/domoticz/hardware/MQTT.cpp:2:
/usr/include/mosquittopp.h:49:30: note: declared here
 mosqpp_EXPORT int DEPRECATED lib_cleanup();
                              ^~~~~~~~~~~
/tmp/domoticz/hardware/MQTT.cpp:52:22: warning: 'int mosqpp::lib_cleanup()' is deprecated [-Wdeprecated-declarations]
  mosqpp::lib_cleanup();
                      ^
In file included from /tmp/domoticz/hardware/MQTT.h:10,
                 from /tmp/domoticz/hardware/MQTT.cpp:2:
/usr/include/mosquittopp.h:49:30: note: declared here
 mosqpp_EXPORT int DEPRECATED lib_cleanup();
                              ^~~~~~~~~~~
/tmp/domoticz/hardware/MQTT.cpp:52:22: warning: 'int mosqpp::lib_cleanup()' is deprecated [-Wdeprecated-declarations]
  mosqpp::lib_cleanup();
                      ^
In file included from /tmp/domoticz/hardware/MQTT.h:10,
                 from /tmp/domoticz/hardware/MQTT.cpp:2:
/usr/include/mosquittopp.h:49:30: note: declared here
 mosqpp_EXPORT int DEPRECATED lib_cleanup();
                              ^~~~~~~~~~~
/tmp/domoticz/hardware/MQTT.cpp: In member function 'void MQTT::StopMQTT()':
/tmp/domoticz/hardware/MQTT.cpp:74:13: warning: 'int mosqpp::mosquittopp::disconnect()' is deprecated [-Wdeprecated-declarations]
  disconnect();
             ^
In file included from /tmp/domoticz/hardware/MQTT.h:10,
                 from /tmp/domoticz/hardware/MQTT.cpp:2:
/usr/include/mosquittopp.h:108:18: note: declared here
   int DEPRECATED disconnect();
                  ^~~~~~~~~~
/tmp/domoticz/hardware/MQTT.cpp: In member function 'virtual void MQTT::on_connect(int)':
/tmp/domoticz/hardware/MQTT.cpp:136:36: warning: 'int mosqpp::mosquittopp::subscribe(int*, const char*, int)' is deprecated [-Wdeprecated-declarations]
   subscribe(NULL, m_TopicIn.c_str());
                                    ^
In file included from /tmp/domoticz/hardware/MQTT.h:10,
                 from /tmp/domoticz/hardware/MQTT.cpp:2:
/usr/include/mosquittopp.h:110:18: note: declared here
   int DEPRECATED subscribe(int *mid, const char *sub, int qos=0);
                  ^~~~~~~~~
/tmp/domoticz/hardware/MQTT.cpp: In member function 'bool MQTT::ConnectIntEx()':
/tmp/domoticz/hardware/MQTT.cpp:513:72: warning: 'int mosqpp::mosquittopp::tls_opts_set(int, const char*, const char*)' is deprecated [-Wdeprecated-declarations]
   rc = tls_opts_set(SSL_VERIFY_PEER, szTLSVersions[m_TLS_Version], NULL);
                                                                        ^
In file included from /tmp/domoticz/hardware/MQTT.h:10,
                 from /tmp/domoticz/hardware/MQTT.cpp:2:
/usr/include/mosquittopp.h:117:18: note: declared here
   int DEPRECATED tls_opts_set(int cert_reqs, const char *tls_version=NULL, const char *ciphers=NULL);
                  ^~~~~~~~~~~~
/tmp/domoticz/hardware/MQTT.cpp:514:36: warning: 'int mosqpp::mosquittopp::tls_set(const char*, const char*, const char*, const char*, int (*)(char*, int, int, void*))' is deprecated [-Wdeprecated-declarations]
   rc = tls_set(m_CAFilename.c_str());
                                    ^
In file included from /tmp/domoticz/hardware/MQTT.h:10,
                 from /tmp/domoticz/hardware/MQTT.cpp:2:
/usr/include/mosquittopp.h:116:18: note: declared here
   int DEPRECATED tls_set(const char *cafile, const char *capath=NULL, const char *certfile=NULL, const char *keyfile=NULL, int (*pw_callback)(char *buf, int size, int rwflag, void *userdata)=NULL);
                  ^~~~~~~
/tmp/domoticz/hardware/MQTT.cpp:524:123: warning: 'int mosqpp::mosquittopp::username_pw_set(const char*, const char*)' is deprecated [-Wdeprecated-declarations]
  rc = username_pw_set((!m_UserName.empty()) ? m_UserName.c_str() : NULL, (!m_Password.empty()) ? m_Password.c_str() : NULL);
                                                                                                                           ^
In file included from /tmp/domoticz/hardware/MQTT.h:10,
                 from /tmp/domoticz/hardware/MQTT.cpp:2:
/usr/include/mosquittopp.h:101:18: note: declared here
   int DEPRECATED username_pw_set(const char *username, const char *password=NULL);
                  ^~~~~~~~~~~~~~~
/tmp/domoticz/hardware/MQTT.cpp:526:59: warning: 'int mosqpp::mosquittopp::connect(const char*, int, int)' is deprecated [-Wdeprecated-declarations]
  rc = connect(m_szIPAddress.c_str(), m_usIPPort, keepalive);
                                                           ^
In file included from /tmp/domoticz/hardware/MQTT.h:10,
                 from /tmp/domoticz/hardware/MQTT.cpp:2:
/usr/include/mosquittopp.h:102:18: note: declared here
   int DEPRECATED connect(const char *host, int port=1883, int keepalive=60);
                  ^~~~~~~
/tmp/domoticz/hardware/MQTT.cpp: In member function 'void MQTT::Do_Work()':
/tmp/domoticz/hardware/MQTT.cpp:548:19: warning: 'int mosqpp::mosquittopp::loop(int, int)' is deprecated [-Wdeprecated-declarations]
     int rc = loop();
                   ^
In file included from /tmp/domoticz/hardware/MQTT.h:10,
                 from /tmp/domoticz/hardware/MQTT.cpp:2:
/usr/include/mosquittopp.h:122:18: note: declared here
   int DEPRECATED loop(int timeout=-1, int max_packets=1);
                  ^~~~
/tmp/domoticz/hardware/MQTT.cpp:556:19: warning: 'int mosqpp::mosquittopp::reconnect()' is deprecated [-Wdeprecated-declarations]
         reconnect();
                   ^
In file included from /tmp/domoticz/hardware/MQTT.h:10,
                 from /tmp/domoticz/hardware/MQTT.cpp:2:
/usr/include/mosquittopp.h:106:18: note: declared here
   int DEPRECATED reconnect();
                  ^~~~~~~~~
/tmp/domoticz/hardware/MQTT.cpp:568:17: warning: 'int mosqpp::mosquittopp::reconnect()' is deprecated [-Wdeprecated-declarations]
       reconnect();
                 ^
In file included from /tmp/domoticz/hardware/MQTT.h:10,
                 from /tmp/domoticz/hardware/MQTT.cpp:2:
/usr/include/mosquittopp.h:106:18: note: declared here
   int DEPRECATED reconnect();
                  ^~~~~~~~~
/tmp/domoticz/hardware/MQTT.cpp:604:2: error: 'clear_callbacks' was not declared in this scope
  clear_callbacks();
  ^~~~~~~~~~~~~~~
/tmp/domoticz/hardware/MQTT.cpp:604:2: note: suggested alternative: 'lua_callk'
  clear_callbacks();
  ^~~~~~~~~~~~~~~
  lua_callk
/tmp/domoticz/hardware/MQTT.cpp:607:14: warning: 'int mosqpp::mosquittopp::disconnect()' is deprecated [-Wdeprecated-declarations]
   disconnect();
              ^
In file included from /tmp/domoticz/hardware/MQTT.h:10,
                 from /tmp/domoticz/hardware/MQTT.cpp:2:
/usr/include/mosquittopp.h:108:18: note: declared here
   int DEPRECATED disconnect();
                  ^~~~~~~~~~
/tmp/domoticz/hardware/MQTT.cpp: In member function 'void MQTT::SendMessage(const string&, const string&)':
/tmp/domoticz/hardware/MQTT.cpp:630:63: warning: 'int mosqpp::mosquittopp::publish(int*, const char*, int, const void*, int, bool)' is deprecated [-Wdeprecated-declarations]
   publish(NULL, Topic.c_str(), Message.size(), Message.c_str());
                                                               ^
In file included from /tmp/domoticz/hardware/MQTT.h:10,
                 from /tmp/domoticz/hardware/MQTT.cpp:2:
/usr/include/mosquittopp.h:109:18: note: declared here
   int DEPRECATED publish(int *mid, const char *topic, int payloadlen=0, const void *payload=NULL, int qos=0, bool retain=false);
                  ^~~~~~~
make[2]: *** [CMakeFiles/domoticz.dir/build.make:1415: CMakeFiles/domoticz.dir/hardware/MQTT.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:75: CMakeFiles/domoticz.dir/all] Error 2
make: *** [Makefile:152: all] Error 2

[tobbenb]

I'll see if I get some time to check it this week. Away for work, but my VPN should be working again.

[CHBMB]

@tobbenb Can we close this in light of your PR 8 days ago?

#64
#65

[thelamer]

Yes everything is building now