feat!: allow to validate asset checksums only TDE-1134 #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulfouquet
requested review from
l0b0,
blacha,
amfage,
MDavidson17 and
Wentao-Kuang
l0b0
approved these changes
May 8, 2024
MDavidson17
approved these changes
May 8, 2024
3 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 8, 2024
🤖 I have created a release *beep* *boop* --- ## [4.0.0](v3.7.0...v4.0.0) (2024-05-08) ### ⚠ BREAKING CHANGES * allow to validate asset checksums only TDE-1134 ([#982](#982)) ### Features * allow to validate asset checksums only TDE-1134 ([#982](#982)) ([aca5939](aca5939)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-merge-queue bot
pushed a commit
to linz/topo-workflows
that referenced
this pull request
May 9, 2024
) #### Motivation `stac-validate` has changed its flags for checksum validation in linz/argo-tasks#982 & linz/argo-tasks#972 #### Modification Use the `--checksum-assets` and `--checksum-links` flags #### Checklist _If not applicable, provide explanation of why._ - [ ] Tests updated NA - [x] Docs updated - [x] Issue linked in Title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Current
--checksumand--checksum-linksflags overlap in the following case--checksum --checksum-links, where--checksumwill validate both asset and link checksums so--checksum-linksbecomes pointless and confusing in that case.Modification
Allow to validate the asset checksums only.
--checksum-assets --checksum-links--checksum-assets--checksum-linksChecklist
If not applicable, provide explanation of why.